Refactor logging configuration to create timestamped run directories for logs

Author: yichao-liang

predicators/approaches/agent_planner_approach.py

@@ -56,8 +56,6 @@ def __init__(self, initial_predicates: Set[Predicate],
             self._option_model = create_option_model(CFG.option_model_name)
         self._online_learning_cycle = 0
         self._requests_train_task_idxs: Optional[List[int]] = None
-
-        # Create unique run identifier for this execution
         self._run_id = datetime.datetime.now().strftime("%Y%m%d_%H%M%S")
 
         self._init_agent_session_state(types, initial_predicates,
@@ -72,12 +70,11 @@ def is_learning_based(self) -> bool:
         return True
 
     def _get_log_dir(self) -> str:
-        """Override to create separate directory for each run."""
-        base_log_dir = super()._get_log_dir()
-        run_log_dir = os.path.join(base_log_dir, f"run_{self._run_id}")
-        os.makedirs(run_log_dir, exist_ok=True)
-        logging.info(f"Logging agent queries/responses to: {run_log_dir}")
-        return run_log_dir
+        """Return per-run log directory (created by configure_logging)."""
+        log_dir = super()._get_log_dir()
+        os.makedirs(log_dir, exist_ok=True)
+        logging.info(f"Logging agent queries/responses to: {log_dir}")
+        return log_dir
 
     # ------------------------------------------------------------------ #
     # Overridable helpers (for subclass customisation)

predicators/utils.py

@@ -4891,22 +4891,23 @@ def configure_logging() -> None:
     colorlog_handler.setFormatter(colored_formatter)
     handlers: List[logging.Handler] = [colorlog_handler]
     if CFG.log_file:
-        CFG.log_file += f"{CFG.approach}/{CFG.experiment_id}/seed{CFG.seed}/"
+        timestamp = datetime.datetime.now().strftime("%Y%m%d_%H%M%S")
+        CFG.log_file += (f"{CFG.approach}/{CFG.experiment_id}/"
+                         f"seed{CFG.seed}/run_{timestamp}/")
         os.makedirs(CFG.log_file, exist_ok=True)
 
-        timestamp = datetime.datetime.now().strftime("%m%d%H%M%S")
         # Handler for DEBUG level messages
-        debug_handler = logging.FileHandler(f"{CFG.log_file}{timestamp}_debug",
-                                            mode='w')
+        debug_handler = logging.FileHandler(
+            os.path.join(CFG.log_file, "debug.log"), mode='w')
         debug_handler.setLevel(logging.DEBUG)
-        debug_handler.setFormatter(colored_formatter)  # Apply formatter
+        debug_handler.setFormatter(colored_formatter)
         handlers.append(debug_handler)
 
         # Handler for INFO level messages
-        info_handler = logging.FileHandler(f"{CFG.log_file}{timestamp}_info",
-                                           mode='w')
+        info_handler = logging.FileHandler(
+            os.path.join(CFG.log_file, "info.log"), mode='w')
         info_handler.setLevel(logging.INFO)
-        info_handler.setFormatter(colored_formatter)  # Apply formatter
+        info_handler.setFormatter(colored_formatter)
         handlers.append(info_handler)
 
     logging.basicConfig(level=CFG.loglevel,