refactor: Replace Logger with 3 functions

Author: youngwayfarer

environment/src/lib.rs

@@ -1,25 +1,21 @@
 use colored::*;
 
-pub struct Logger;
-
-impl Logger {
-    pub fn info(msg: &str) {
-        println!("{} {}", "[xtask]".green().bold(), msg);
-    }
+pub fn info(msg: &str) {
+    println!("{} {}", "[xtask]".green().bold(), msg);
+}
 
-    pub fn error(msg: &str) {
-        println!("{} {}", "[xtask]".red().bold(), msg);
-    }
+pub fn error(msg: &str) {
+    println!("{} {}", "[xtask]".red().bold(), msg);
+}
 
-    pub fn warning(msg: &str) {
-        println!("{} {}", "[xtask]".yellow().bold(), msg);
-    }
+pub fn warning(msg: &str) {
+    println!("{} {}", "[xtask]".yellow().bold(), msg);
 }
 
 pub fn install_env(env: &str) {
     match env {
         "Python" => {
-            Logger::info("Checking if Python is already installed...");
+            info("Checking if Python is already installed...");
             println!();
 
             // Check if python or python3 is installed
@@ -40,11 +36,11 @@ pub fn install_env(env: &str) {
             };
 
             if check_installed {
-                Logger::info("Python is already installed. No need to reinstall.");
+                info("Python is already installed. No need to reinstall.");
                 return;
             }
 
-            Logger::info("Python not detected. Installing Python environment...");
+            info("Python not detected. Installing Python environment...");
 
             #[cfg(target_os = "windows")]
             let output = std::process::Command::new("powershell")
@@ -90,26 +86,26 @@ pub fn install_env(env: &str) {
                         .arg("brew install python")
                         .status()
                 } else {
-                    Logger::error(
+                    error(
                         "No supported package manager found (apt-get, dnf, yum, pacman). Please install Python manually.",
                     );
                     return;
                 }
             };
 
             match output {
-                Ok(status) if status.success() => Logger::info("Python installation completed!"),
-                Ok(status) => Logger::error(&format!(
+                Ok(status) if status.success() => info("Python installation completed!"),
+                Ok(status) => error(&format!(
                     "Python installation failed, exit code: {:?}",
                     status.code()
                 )),
-                Err(e) => Logger::error(&format!(
+                Err(e) => error(&format!(
                     "Error occurred while running install command: {e}"
                 )),
             }
         }
         "xmake" => {
-            Logger::info("Checking if xmake is already installed...");
+            info("Checking if xmake is already installed...");
             println!();
 
             // Check if xmake is installed
@@ -121,11 +117,11 @@ pub fn install_env(env: &str) {
                 .unwrap_or(false);
 
             if check_installed {
-                Logger::info("xmake is already installed. No need to reinstall.");
+                info("xmake is already installed. No need to reinstall.");
                 return;
             }
 
-            Logger::info("xmake not detected. Installing xmake environment...");
+            info("xmake not detected. Installing xmake environment...");
 
             #[cfg(target_os = "windows")]
             let output = std::process::Command::new("powershell")
@@ -142,18 +138,18 @@ pub fn install_env(env: &str) {
                 .status();
 
             match output {
-                Ok(status) if status.success() => Logger::info("xmake installation completed!"),
-                Ok(status) => Logger::error(&format!(
+                Ok(status) if status.success() => info("xmake installation completed!"),
+                Ok(status) => error(&format!(
                     "xmake installation failed, exit code: {:?}",
                     status.code()
                 )),
-                Err(e) => Logger::error(&format!(
+                Err(e) => error(&format!(
                     "Error occurred while running install command: {e}"
                 )),
             }
         }
         "CUDA" => {
-            Logger::info("Checking if CUDA Toolkit is already installed...");
+            info("Checking if CUDA Toolkit is already installed...");
             println!();
 
             // Check if cuda toolkit is installed
@@ -165,7 +161,7 @@ pub fn install_env(env: &str) {
                 .unwrap_or(false);
 
             if check_installed {
-                Logger::info("CUDA Toolkit is already installed. No need to reinstall.");
+                info("CUDA Toolkit is already installed. No need to reinstall.");
                 return;
             }
 
@@ -183,57 +179,57 @@ pub fn install_env(env: &str) {
                 let smi_info = String::from_utf8_lossy(&output.stdout);
                 for line in smi_info.lines() {
                     if line.contains("CUDA Version") {
-                        Logger::info(&format!("Detected by nvidia-smi: {line}"));
+                        info(&format!("Detected by nvidia-smi: {line}"));
                     }
                     if let Some(idx) = line.find("CUDA Version:") {
                         // extract the CUDA version number
                         let version_str = line[idx + "CUDA Version:".len()..]
                             .split_whitespace()
                             .next()
                             .unwrap_or("");
-                        Logger::info(&format!(
+                        info(&format!(
                             "The highest CUDA version supported by your driver is {version_str}"
                         ));
-                        Logger::warning(
+                        warning(
                             "You can also visit https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html to find the CUDA version compatible with your GPU driver.",
                         );
                     }
                 }
-                Logger::info(
+                info(
                     "Please make sure to install a CUDA Toolkit version compatible with your driver.",
                 );
             } else {
-                Logger::error(
+                error(
                     "nvidia-smi not found. Please make sure you have an NVIDIA GPU and drivers installed.",
                 );
             }
 
             println!();
-            Logger::warning(
+            warning(
                 "Please visit https://developer.nvidia.com/cuda-toolkit-archive to select and download the appropriate CUDA version for your driver.",
             );
         }
         "OpenCL" => {
-            Logger::info(
+            info(
                 "The current automatic installation script only supports OpenCL installation for Intel CPU on Windows or Ubuntu systems.",
             );
-            Logger::info("Checking if OpenCL is already installed...");
+            info("Checking if OpenCL is already installed...");
             println!();
 
             // Check if OpenCL is installed
             #[cfg(target_os = "windows")]
             {
                 let clinfo_path = std::path::Path::new("clinfo.exe");
                 if !clinfo_path.exists() {
-                    Logger::info("Downloading clinfo tool...");
+                    info("Downloading clinfo tool...");
                     let download_status = std::process::Command::new("curl")
                         .args(["-o", "clinfo.exe", "https://github.com/ahoylabs/clinfo/releases/download/master-d2baa06/clinfo.exe"])
                         .status();
 
                     if let Err(e) = download_status {
-                        Logger::error(&format!("Failed to download clinfo: {}", e));
-                        Logger::warning("You may need to enable proxy.");
-                        Logger::warning(
+                        error(&format!("Failed to download clinfo: {}", e));
+                        warning("You may need to enable proxy.");
+                        warning(
                             "You can also manually download from https://github.com/ahoylabs/clinfo/releases/download/master-d2baa06/clinfo.exe",
                         );
                         return;
@@ -251,19 +247,19 @@ pub fn install_env(env: &str) {
                 {
                     if let Some(number) = line.split_whitespace().last() {
                         if number == "0" {
-                            Logger::info("OpenCL is not installed.");
+                            info("OpenCL is not installed.");
                         } else {
-                            Logger::info(&format!(
+                            info(&format!(
                                 "OpenCL is installed. Number of platforms: {}",
                                 number
                             ));
                             return;
                         }
                     } else {
-                        Logger::error("Failed to parse the number of platforms.");
+                        error("Failed to parse the number of platforms.");
                     }
                 } else {
-                    Logger::error("Failed to find 'Number of platforms' in clinfo output.");
+                    error("Failed to find 'Number of platforms' in clinfo output.");
                 }
             }
             #[cfg(not(target_os = "windows"))]
@@ -280,20 +276,18 @@ pub fn install_env(env: &str) {
 
                 if !has_cmd("clinfo") {
                     if has_cmd("apt") {
-                        Logger::info("Installing clinfo tool...");
+                        info("Installing clinfo tool...");
                         let install_status = std::process::Command::new("sh")
                             .arg("-c")
                             .arg("sudo apt update && sudo apt install opencl-headers ocl-icd-opencl-dev -y")
                             .status();
 
                         if let Err(e) = install_status {
-                            Logger::error(&format!("Failed to install clinfo: {}", e));
+                            error(&format!("Failed to install clinfo: {}", e));
                             return;
                         }
                     } else {
-                        Logger::error(
-                            "Unsupported package manager. Please install clinfo manually.",
-                        );
+                        error("Unsupported package manager. Please install clinfo manually.");
                         return;
                     }
                 }
@@ -309,23 +303,23 @@ pub fn install_env(env: &str) {
                 {
                     if let Some(number) = line.split_whitespace().last() {
                         if number == "0" {
-                            Logger::info("OpenCL is not installed.");
+                            info("OpenCL is not installed.");
                         } else {
-                            Logger::info(&format!(
+                            info(&format!(
                                 "OpenCL is installed. Number of platforms: {}",
                                 number
                             ));
                             return;
                         }
                     } else {
-                        Logger::error("Failed to parse the number of platforms.");
+                        error("Failed to parse the number of platforms.");
                     }
                 } else {
-                    Logger::error("Failed to find 'Number of platforms' in clinfo output.");
+                    error("Failed to find 'Number of platforms' in clinfo output.");
                 }
             }
 
-            Logger::info("OpenCL not detected. Installing OpenCL environment...");
+            info("OpenCL not detected. Installing OpenCL environment...");
 
             #[cfg(target_os = "windows")]
             {
@@ -334,18 +328,18 @@ pub fn install_env(env: &str) {
                     .status();
 
                 if let Err(e) = download_status {
-                    Logger::error(&format!(
+                    error(&format!(
                         "Failed to download w_opencl_runtime_p_2025.1.0.972: {}",
                         e
                     ));
-                    Logger::warning("You may need to enable proxy.");
-                    Logger::warning(
+                    warning("You may need to enable proxy.");
+                    warning(
                         "You can also manually download from https://registrationcenter-download.intel.com/akdlm/IRC_NAS/b6dccdb7-b503-41ea-bd4b-a78e9c2d8dd6/w_opencl_runtime_p_2025.1.0.972.exe",
                     );
                     return;
                 }
 
-                Logger::warning(
+                warning(
                     "Download completed. Please manually execute 'w_opencl_runtime_p_2025.1.0.972.exe' to install OpenCL for Intel CPU.",
                 );
             }
@@ -362,18 +356,18 @@ pub fn install_env(env: &str) {
                 };
 
                 if has_cmd("apt") {
-                    Logger::info("Installing opencl-headers...");
+                    info("Installing opencl-headers...");
                     let install_status = std::process::Command::new("sh")
                         .arg("-c")
                         .arg("sudo apt update && sudo apt install opencl-headers ocl-icd-opencl-dev -y")
                         .status();
 
                     if let Err(e) = install_status {
-                        Logger::error(&format!("Failed to install OpenCL: {}", e));
+                        error(&format!("Failed to install OpenCL: {}", e));
                         return;
                     }
 
-                    Logger::info("Installing Intel OpenCL runtime...");
+                    info("Installing Intel OpenCL runtime...");
                     let setup_status = std::process::Command::new("sh")
                         .arg("-c")
                         .arg(
@@ -385,23 +379,23 @@ pub fn install_env(env: &str) {
                         .status();
 
                     if let Err(e) = setup_status {
-                        Logger::error(&format!("Failed to set up Intel OpenCL repository: {}", e));
+                        error(&format!("Failed to set up Intel OpenCL repository: {}", e));
                         return;
                     }
 
-                    Logger::warning(
+                    warning(
                         "Intel OpenCL runtime installation requires a proxy and may take time.",
                     );
-                    Logger::warning(
+                    warning(
                         "Please manually execute the following command after enabling the proxy:",
                     );
-                    Logger::warning("sudo apt install -y intel-oneapi-runtime-opencl");
+                    warning("sudo apt install -y intel-oneapi-runtime-opencl");
                 } else {
-                    Logger::error("Unsupported package manager. Please install OpenCL manually.");
+                    error("Unsupported package manager. Please install OpenCL manually.");
                 }
             }
         }
-        _ => Logger::error(&format!(
+        _ => error(&format!(
             "Automatic installation for this environment is not supported: {env}"
         )),
     }