fix: Uses persona ID for personas without a name (LLC-57) (#293)

Author: PrinceWaune

src/mongoModelsRepo/createPersona.ts

@@ -8,20 +8,20 @@ import { PERSONAS_COLLECTION } from './utils/constants/collections';
 export default (config: Config) => {
   return async (opts: CreatePersonaOptions): Promise<CreatePersonaResult> => {
     const collection = (await config.db).collection(PERSONAS_COLLECTION);
-
-    const docToInsert = {
-      name: opts.name,
-      organisation: new ObjectID(opts.organisation),
-    };
+    const personaId = new ObjectID();
 
     // Docs: http://mongodb.github.io/node-mongodb-native/2.2/api/Collection.html#insertOne
     // Docs: http://bit.ly/insertOneWriteOpResult
-    const opResult = await collection.insertOne(docToInsert, {});
+    const opResult = await collection.insertOne({
+      _id: personaId,
+      name: Boolean(opts.name) ? opts.name : personaId.toString(),
+      organisation: new ObjectID(opts.organisation),
+    }, {});
 
     // Formats the persona to be returned.
     const persona: Persona = {
       id: opResult.insertedId.toString(),
-      name: opts.name,
+      name: Boolean(opts.name) ? opts.name : personaId.toString(),
       organisation: opts.organisation,
     };
 

src/tests/createPersona/createPersona.test.ts

@@ -1,5 +1,6 @@
 import * as assert from 'assert';
 import createTestPersona from '../utils/createTestPersona';
+import createTestPersonaWithoutName from '../utils/createTestPersonaWithoutName';
 import setup from '../utils/setup';
 import { TEST_ORGANISATION } from '../utils/values';
 
@@ -18,4 +19,16 @@ describe('createPersona', () => {
     assert.equal(actualPersona.name, 'Dave');
     assert.equal(actualPersona.organisation, TEST_ORGANISATION);
   });
+
+  it('Should create a persona with personaId instead name, if name not exists.', async () => {
+    const persona = await createTestPersonaWithoutName();
+    const {persona: actualPersona} = await service.getPersona({
+      organisation: TEST_ORGANISATION,
+      personaId: persona.id,
+    });
+
+    assert.equal(actualPersona.id, persona.id);
+    assert.equal(actualPersona.name, persona.id.toString());
+    assert.equal(actualPersona.organisation, TEST_ORGANISATION);
+  });
 });

src/tests/utils/createTestPersona.ts

@@ -1,7 +1,7 @@
 // tslint:disable-next-line:no-unused
 import PersonaModel from '../../models/Persona';
 import service from '../../tester';
-import { TEST_ORGANISATION } from '../utils/values';
+import { TEST_ORGANISATION } from './values';
 
 export default async (name?: string, organisation: string = TEST_ORGANISATION) => {
   const {persona} = await service.createPersona({

src/tests/utils/createTestPersonaWithoutName.ts

@@ -0,0 +1,11 @@
+// tslint:disable-next-line:no-unused
+import PersonaModel from '../../models/Persona';
+import service from '../../tester';
+import { TEST_ORGANISATION } from './values';
+
+export default async (organisation: string = TEST_ORGANISATION) => {
+  const {persona} = await service.createPersona({
+    organisation,
+  });
+  return persona;
+};