fix: Allows persona creation without name (LLC-57) (#305)

Author: cbishopvelti

src/mongoModelsRepo/createPersona.ts

@@ -8,20 +8,18 @@ import { PERSONAS_COLLECTION } from './utils/constants/collections';
 export default (config: Config) => {
   return async (opts: CreatePersonaOptions): Promise<CreatePersonaResult> => {
     const collection = (await config.db).collection(PERSONAS_COLLECTION);
-    const personaId = new ObjectID();
 
     // Docs: http://mongodb.github.io/node-mongodb-native/2.2/api/Collection.html#insertOne
     // Docs: http://bit.ly/insertOneWriteOpResult
     const opResult = await collection.insertOne({
-      _id: personaId,
-      name: Boolean(opts.name) ? opts.name : personaId.toString(),
+      name: opts.name,
       organisation: new ObjectID(opts.organisation),
     }, {});
 
     // Formats the persona to be returned.
     const persona: Persona = {
       id: opResult.insertedId.toString(),
-      name: Boolean(opts.name) ? opts.name : personaId.toString(),
+      name: opts.name,
       organisation: opts.organisation,
     };
 

src/tests/createPersona/createPersona.test.ts

@@ -1,11 +1,9 @@
 import * as assert from 'assert';
 import createTestPersona from '../utils/createTestPersona';
-import createTestPersonaWithoutName from '../utils/createTestPersonaWithoutName';
 import setup from '../utils/setup';
 import { TEST_ORGANISATION } from '../utils/values';
 
 describe('createPersona', () => {
-
   const service = setup();
 
   it('Should create persona', async () => {
@@ -19,16 +17,4 @@ describe('createPersona', () => {
     assert.equal(actualPersona.name, 'Dave');
     assert.equal(actualPersona.organisation, TEST_ORGANISATION);
   });
-
-  it('Should create a persona with personaId instead name, if name not exists.', async () => {
-    const persona = await createTestPersonaWithoutName();
-    const {persona: actualPersona} = await service.getPersona({
-      organisation: TEST_ORGANISATION,
-      personaId: persona.id,
-    });
-
-    assert.equal(actualPersona.id, persona.id);
-    assert.equal(actualPersona.name, persona.id.toString());
-    assert.equal(actualPersona.organisation, TEST_ORGANISATION);
-  });
 });