fix(server): flush outbound queue before closing ports + silence CI trace spam#69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloseAllPorts()data loss fix: When the ApplicationBridge's upstreamfinish triggered
CloseAllPorts(), any response data still queued in_outboundQueuewas silently discarded — the method calledComplete(_outNetwork)without draining the queue first. Under CI load(Linux, Docker matrix variant), this race caused the H1.0 E2E roundtrip
test to fail with "HTTP/1.0 connection closed before response body was
complete." Now routes through
CompleteAfterFlushingOutbound()when thequeue is non-empty.
Tracing leak in
ServerStartupReliabilitySpec: The test configuredglobal
Debug-level Senf tracing on stderr but never disabled it. SinceServus.Senf.Tracingis a process-wide singleton, all subsequent testsinherited the debug listener — flooding CI logs with thousands of
[Debug][Stage]lines in the Docker matrix variant. AddedTracing.Disable()in thefinallyblock.Test plan