fix async withdrawal gas fee: forward msg.value only, settle state before eth send#1
Open
mooncitydev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey team, noticed something odd on requestWithdrawal while reading next to LToken.
LedgityYieldVault was doing feeRecipient.call with address(this).balance. So anything else sitting on the vault in wei (forced ETH, coinbase, leftover weirdness) went to the fee recipient together with the users prepaid fee. Same tx still looked fine if the vault had zero extra wei, which is probably why it slipped through.
v1 LToken.requestWithdrawal already forwards msg.value only, so this brings v2 in line and avoids sweeping unrelated balance.
Also moved the eth transfer to after the burn and the queue write so we are not doing an external call with value before the main state updates (same pattern as sticking transfers last).
Added a small unit test that vm.deals stray wei onto the vault and checks the recipient only gets the attached gas fee.
cheers