Skip to content

Commit 3d73934

Browse files
committed
fix: restore vertical spacing for native button elements
Re-add margin-block-end to <button> and button-type <input> elements without affecting [role="button"] on non-button elements (e.g. logo). Commit 52cf801 removed all button margin (issue #6) but never replaced the vertical spacing, causing wrapped buttons to collapse together. Scoped to native elements only to avoid shifting @leftium/logo's overlay-aligned div[role="button"].
1 parent ebd10cc commit 3d73934

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/_buttons.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@
3030
transition: background-color 0.2s, border-color 0.2s;
3131
}
3232

33+
// Vertical rhythm for flow-level buttons (not [role="button"] on
34+
// arbitrary elements like logo containers — those opt in manually).
35+
:where(button, [type="submit"], [type="reset"], [type="button"]) {
36+
margin-block-end: 0.25em;
37+
}
38+
3339
:where(button, [type="submit"], [type="reset"], [type="button"], [role="button"]):hover {
3440
background-color: var(#{$prefix}primary-hover);
3541
border-color: var(#{$prefix}primary-hover);

0 commit comments

Comments
 (0)