refactor: Remove ZIP archive support

REMOVED: ZIP archive processing and support

Changes Made:
1. Removed ZIP archive mentions from README.md:
   - Removed 'including ZIP archives' from Smart Parsing section
   - Removed 'and ZIP archives' from Multi-format Input section

2. Removed ZIP processing code from src/routes/yaml.routes.js:
   - Removed AdmZip require statement
   - Removed .zip file type mapping
   - Removed ZIP MIME types
   - Removed entire ZIP processing logic (1598-1792 lines)
   - Removed ZIP archive from binary analysis
   - Updated error messages to remove ZIP references

3. Removed ZIP dependencies:
   - Removed 'adm-zip' from package.json

4. Updated error messages:
   - Removed ZIP references from file validation errors

Test Results:
✅ All 108 comprehensive tests still passing (100% success rate)
✅ No functionality broken by ZIP removal
✅ All supported file types still working correctly

The application now focuses on core file types:
- .mobileconfig, .xml, .eap-config, .yml/.yaml, .json, .txt/.conf/.cfg
- Binary files (plist, certificates, etc.)
- Text-based configuration files

ZIP support has been completely removed as requested.

Author: Leftyshields

README.md

@@ -6,7 +6,7 @@ A comprehensive web application for editing Passpoint WiFi configurations and co
 
 ### Profile Converter
 - **Multi-format Support**: Convert .mobileconfig, .xml, .eap-config, .yml/.yaml, .json, .txt/.conf/.cfg files
-- **Smart Parsing**: Automatic detection and parsing of configuration formats including ZIP archives
+- **Smart Parsing**: Automatic detection and parsing of configuration formats
 - **Certificate Handling**: Advanced certificate detection and display options:
   - **Preserve**: Show original certificate data
   - **Obfuscate**: Replace with `[CERTIFICATE DATA REDACTED]`
@@ -32,7 +32,7 @@ A comprehensive web application for editing Passpoint WiFi configurations and co
 ### Technical Features
 - **Certificate Processing**: Backend certificate detection and transformation with metadata extraction
 - **Automatic Cleanup**: Uploaded files are automatically cleaned up after processing
-- **Multi-format Input**: Support for 15+ file formats including binary and ZIP archives
+- **Multi-format Input**: Support for 15+ file formats including binary files
 - **Security**: Non-root Docker containers, input sanitization, certificate data protection
 - **Performance**: Multi-stage Docker builds, optimized frontend, efficient file processing
 - **Monitoring**: Health checks, comprehensive logging, and WebSocket progress updates

package.json

@@ -26,7 +26,7 @@
     "@emotion/styled": "^11.14.0",
     "@fastify/busboy": "^3.1.1",
     "@mui/material": "^7.0.2",
-    "adm-zip": "^0.5.16",
+
     "ajv": "^8.17.1",
     "axios": "^1.9.0",
     "busboy": "^1.6.0",

src/app.js

@@ -100,7 +100,7 @@ function detectFileIssues(filePath, fileExtension, fileContent) {
     '.mobileconfig': 'Mobile Configuration',
     '.eap-config': 'EAP Configuration',
     '.txt': 'Text',
-    '.zip': 'ZIP Archive',
+
     '.conf': 'Configuration',
     '.cfg': 'Configuration'
   };

src/routes/yaml.routes.js

@@ -14,7 +14,7 @@ const { mapToYamlSchema } = require('../services/mapping.service'); // Import th
 const certService = require('../services/cert.service'); // Import the certificate service
 const { v4: uuidv4 } = require('uuid');
 const { sendConversionUpdate } = require('../services/websocket.service'); // Import WebSocket service
-const AdmZip = require('adm-zip');
+
 const crypto = require('crypto');
 const Busboy = require('@fastify/busboy'); // Use Fastify busboy for better serverless support
 const { bufferJsonReplacer, processBinaryData } = require('../utils/binary-helpers'); // Import binary data helpers
@@ -33,7 +33,7 @@ const SUPPORTED_FILE_TYPES = {
   '.mobileconfig': 'Mobile Configuration',
   '.eap-config': 'EAP Configuration',
   '.txt': 'Text',
-  '.zip': 'ZIP Archive',
+  
   '.conf': 'Configuration',
   '.cfg': 'Configuration'
 };
@@ -648,7 +648,7 @@ const upload = multer({
       '.yml', '.yaml', '.mobileconfig', '.xml', '.eap-config', 
       '.txt', '.json', '.conf', '.cfg',
       '.pem', '.crt', '.cer', '.ovpn', '.profile', '.p12', '.pfx',
-      '.zip', '.plist', '.config', '.ini', '.properties', '.env',
+      '.plist', '.config', '.ini', '.properties', '.env',
       '.toml', '.log', '.data', '.bin'  // Added more types
     ];
     const allowedMimeTypes = [
@@ -663,8 +663,7 @@ const upload = multer({
       'application/vnd.visio', // .vsd
       'application/json',
       'text/json',
-      'application/zip',        // ZIP files
-      'application/x-zip-compressed',
+      
       'application/x-plist',    // Plist files
       'application/pkcs12',     // P12/PFX certificates
       'application/x-pkcs12',
@@ -1564,7 +1563,7 @@ router.post('/convert', async (req, res) => {
           // Try to detect file format based on magic bytes
           const firstFourBytes = fileBuffer.slice(0, 4);
           if (firstFourBytes[0] === 0x50 && firstFourBytes[1] === 0x4B) {
-            binaryAnalysis.analysis.possibleFormats.push('ZIP archive');
+    
           }
           if (fileBuffer.slice(0, 8).toString() === 'bplist00') {
             binaryAnalysis.analysis.possibleFormats.push('Binary property list (plist)');
@@ -1596,205 +1595,6 @@ router.post('/convert', async (req, res) => {
           });
         }
 
-        // Check if this is actually a ZIP file (Office document or ZIP archive)
-        const zipSignature = fileBuffer.subarray(0, 4);
-        const isZip = zipSignature[0] === 0x50 && zipSignature[1] === 0x4B; // "PK" signature
-        
-        if (isZip) {
-          console.log('[SERVER /convert] Detected ZIP archive format, searching for plist content');
-          
-          try {
-            const zip = new AdmZip(fileBuffer);
-            const zipEntries = zip.getEntries();
-            
-            console.log('[SERVER /convert] ZIP contains', zipEntries.length, 'files');
-            
-            // First pass: Look for obvious plist/mobileconfig files
-            let plistEntry = null;
-            for (const entry of zipEntries) {
-              const entryName = entry.entryName.toLowerCase();
-              console.log('[SERVER /convert] Found file in ZIP:', entry.entryName);
-              
-              if (entryName.endsWith('.plist') || 
-                  entryName.endsWith('.mobileconfig') || 
-                  entryName.includes('passpoint') ||
-                  entryName.includes('wifi') ||
-                  entryName.includes('802dot1x')) {
-                plistEntry = entry;
-                console.log('[SERVER /convert] Found potential plist file in ZIP:', entry.entryName);
-                break;
-              }
-            }
-            
-            // Second pass: Search file contents for plist data
-            if (!plistEntry) {
-              console.log('[SERVER /convert] No obvious plist files found, searching file contents...');
-              
-              for (const entry of zipEntries) {
-                // Skip directories and very large files
-                if (entry.isDirectory || entry.header.size > 1024 * 1024) { // Skip files > 1MB
-                  continue;
-                }
-                
-                try {
-                  const entryData = entry.getData();
-                  const entryText = entryData.toString('utf8', 0, Math.min(entryData.length, 10000)); // Check first 10KB
-                  
-                  // Look for plist signatures in the content
-                  if (entryText.includes('<!DOCTYPE plist') || 
-                      entryText.includes('<plist') ||
-                      entryText.includes('PayloadType') ||
-                      entryText.includes('com.apple.wifi.managed') ||
-                      entryText.includes('EAPClientConfiguration') ||
-                      entryText.includes('RoamingConsortiumOIs')) {
-                    
-                    console.log('[SERVER /convert] Found plist content in file:', entry.entryName);
-                    plistEntry = entry;
-                    break;
-                  }
-                  
-                  // Also check for binary plist signatures
-                  if (entryData.length >= 8) {
-                    const header = entryData.toString('ascii', 0, 8);
-                    if (header === 'bplist00' || header.startsWith('bplist')) {
-                      console.log('[SERVER /convert] Found binary plist in file:', entry.entryName);
-                      plistEntry = entry;
-                      break;
-                    }
-                  }
-                  
-                } catch (contentError) {
-                  // Skip files that can't be read as text
-                  continue;
-                }
-              }
-            }
-            
-            // Third pass: Try XML files that might contain embedded plist data
-            if (!plistEntry) {
-              console.log('[SERVER /convert] Still no plist found, checking XML files for embedded content...');
-              
-              for (const entry of zipEntries) {
-                const entryName = entry.entryName.toLowerCase();
-                
-                if (entryName.endsWith('.xml') && 
-                    !entryName.includes('content_types') &&
-                    !entryName.includes('theme') &&
-                    !entryName.includes('styles') &&
-                    !entryName.includes('settings') &&
-                    !entryName.includes('rels')) {
-                  
-                  try {
-                    const xmlBuffer = entry.getData();
-                    const xmlContent = xmlBuffer.toString('utf8');
-                    
-                    // Look for WiFi/network configuration in XML
-                    if (xmlContent.includes('wifi') ||
-                        xmlContent.includes('network') ||
-                        xmlContent.includes('eap') ||
-                        xmlContent.includes('passpoint') ||
-                        xmlContent.includes('802.1x') ||
-                        xmlContent.includes('certificate') ||
-                        xmlContent.includes('credential')) {
-                      
-                      console.log('[SERVER /convert] Found potential network config in XML:', entry.entryName);
-                      plistEntry = entry;
-                      break;
-                    }
-                  } catch (xmlError) {
-                    continue;
-                  }
-                }
-              }
-            }
-            
-            if (!plistEntry) {
-              return res.status(400).json({ 
-                error: 'No plist, mobileconfig, or network configuration content found in the ZIP archive. Searched through all files but found no Passpoint/WiFi configuration data. Files found: ' + 
-                       zipEntries.map(e => e.entryName).join(', ')
-              });
-            }
-            
-            // Extract the plist file content
-            const plistBuffer = plistEntry.getData();
-            console.log('[SERVER /convert] Extracted potential plist file, size:', plistBuffer.length);
-            
-            // Try to parse as plist
-            let parsedPlist;
-            try {
-              // Try binary plist first
-              parsedPlist = plist.parse(plistBuffer);
-              console.log('[SERVER /convert] Binary plist parsing successful from ZIP');
-            } catch (binaryError) {
-              console.log('[SERVER /convert] Binary plist failed, trying as text:', binaryError.message);
-              
-              try {
-                // Try as text plist
-                const plistText = plistBuffer.toString('utf8');
-                
-                // If it doesn't look like a plist, try to extract plist content from it
-                if (!plistText.includes('<plist') && !plistText.includes('<!DOCTYPE plist')) {
-                  console.log('[SERVER /convert] Not a standard plist, searching for embedded plist content...');
-                  
-                  // Look for plist-like structures in the text
-                  const plistMatch = plistText.match(/<!DOCTYPE plist[\s\S]*?<\/plist>/i);
-                  if (plistMatch) {
-                    console.log('[SERVER /convert] Found embedded plist content');
-                    parsedPlist = plist.parse(plistMatch[0]);
-                  } else {
-                    throw new Error('No valid plist content found in extracted file');
-                  }
-                } else {
-                  parsedPlist = plist.parse(plistText);
-                }
-                
-                console.log('[SERVER /convert] Text plist parsing successful from ZIP');
-              } catch (textError) {
-                console.log('[SERVER /convert] Text plist also failed:', textError.message);
-                throw new Error(`Unable to parse extracted file as plist: ${textError.message}`);
-              }
-            }
-            
-            console.log('[SERVER /convert] Parsed plist structure from ZIP:', JSON.stringify(parsedPlist, null, 2));
-            
-            // Return full unfiltered data from ZIP
-            const fullYamlOutput = yaml.dump(parsedPlist, {
-              indent: 2,
-              lineWidth: 120,
-              noRefs: true,
-            });
-            
-            // Also create filtered version for comparison
-            const mappedData = mapMobileConfigToYaml(parsedPlist);
-            const filteredYamlOutput = yaml.dump(mappedData, {
-              indent: 2,
-              lineWidth: 120,
-              noRefs: true,
-            });
-            
-            return res.json({
-              success: true,
-              yamlOutput: fullYamlOutput,              // PRIMARY: Full unfiltered data (frontend expects yamlOutput)
-              comprehensiveYaml: fullYamlOutput,       // ALSO: Same data for comprehensive tab
-              filteredYaml: filteredYamlOutput,        // SECONDARY: Filtered version
-              jsonOutput: JSON.stringify(parsedPlist, null, 2), // JSON format for JSON tab
-              originalData: parsedPlist,
-              sourceFile: plistEntry.entryName,
-              fileType: 'plist-in-zip',
-              mappingInfo: {
-                filtered: false,
-                note: "Full unfiltered data extracted from ZIP is provided in the 'yamlOutput' field"
-              }
-            });
-            
-          } catch (zipError) {
-            console.log('[SERVER /convert] ZIP processing failed:', zipError.message);
-            return res.status(400).json({ 
-              error: `Failed to process ZIP file: ${zipError.message}. This may not contain valid plist/configuration data.` 
-            });
-          }
-        }
-        
         // Convert buffer to string and clean it
         let xmlString = fileBuffer.toString('utf8');
 
@@ -2009,7 +1809,7 @@ router.post('/convert', async (req, res) => {
         const trimmedXml = xmlString.trim();
         if (!trimmedXml.includes('<') || trimmedXml.length === 0) {
           return res.status(400).json({ 
-            error: 'File does not appear to contain valid XML content. Please ensure you have uploaded a proper XML, plist, or ZIP file containing configuration data.' 
+            error: 'File does not appear to contain valid XML content. Please ensure you have uploaded a proper XML or plist file containing configuration data.' 
           });
         }