docs: recommend SHA-256 for new OAEP usage#912
Open
salasebas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #906.
Summary
This keeps the RSAES-OAEP default hash algorithm as SHA-1 for compatibility with RFC 8017 and existing ciphertexts, but updates the documentation to recommend SHA-256 explicitly for new protocols.
Changes included:
hashAlgo=SHA256.hashAlgodocstring inCrypto.Cipher.PKCS1_OAEP.Rationale
Changing the default hash algorithm would silently break interoperability and decryption of existing OAEP ciphertexts created with the current default. A documentation/example update gives new users safer guidance without introducing a backward compatibility break.
Tests
python3 setup.py build_ext -ienv PYTHONPATH=lib:test_vectors python3 -c 'import unittest; from Crypto.SelfTest.Cipher import test_pkcs1_oaep; suite=unittest.TestSuite(test_pkcs1_oaep.get_tests({"slow_tests": False, "wycheproof_warnings": False})); result=unittest.TextTestRunner(verbosity=2).run(suite); raise SystemExit(0 if result.wasSuccessful() else 1)'git diff --check