Support importing OpenSSH public certificates#913
Open
salasebas wants to merge 1 commit into
Open
Conversation
Add parsing for OpenSSH public certificate lines and return the embedded RSA, DSA, ECDSA, or Ed25519 public key without exposing or verifying certificate metadata. Refs Legrandin#843
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssh-rsa-cert-v01@openssh.comNotes
This does not expose certificate metadata and does not verify CA signatures, principals, validity windows, critical options, or extensions. It only imports the embedded public key, matching the existing
import_key()API shape.Closes #843
Tests
PYTHONPATH=lib python3 -m Crypto.SelfTest.PublicKey.test_import_RSAPYTHONPATH=lib python3 -m Crypto.SelfTest.PublicKey.test_import_DSAPYTHONPATH=lib python3 -m Crypto.SelfTest.PublicKey.test_import_ECCPYTHONPATH=lib:test_vectors python3 -m Crypto.SelfTest.PublicKey.test_import_RSAPYTHONPATH=lib:test_vectors python3 -m Crypto.SelfTest.PublicKey.test_import_DSAPYTHONPATH=lib:test_vectors python3 -m Crypto.SelfTest.PublicKey.test_import_ECC