Skip to content

Change large card view to use full width #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nutomic wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Change large card view to use full width #4110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0668dfb
Change large card view to use full width
Nutomic May 19, 2026
4357201
Merge branch 'main' into card-full-width
Nutomic May 25, 2026
0c3ea07
fix large card image size
Nutomic May 28, 2026
3dcd5f4
handle more
Nutomic May 28, 2026
c5af053
large thumbnail
Nutomic Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shared/components/common/media-uploads.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class MediaUploads extends Component<Props, never> {
<div className={cols}>
<PictrsImage
src={buildImageUrl(i.local_image.pictrs_alias)}
type="full_size"
type="large_thumbnail"
/>
</div>
<div className={cols}>{this.deleteImageBtn(i.local_image)}</div>
Expand Down
9 changes: 8 additions & 1 deletion src/shared/components/common/pictrs-image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const defaultImgSize = 512;
const bannerSize = 2048;

type PictrsImageType =
| "full_size"
| "large_thumbnail"
| "thumbnail"
| "icon"
| "banner"
Expand Down Expand Up @@ -195,9 +195,16 @@ export function buildPictrsSrc(src: string, type: PictrsImageType): string {
url.searchParams.set("max_size", thumbnailSize.toString());
break;
case "icon":
case "icon_without_banner":
url.searchParams.set("max_size", iconThumbnailSize.toString());
break;
case "banner":
case "icon_and_banner":
case "card_top":
url.searchParams.set("max_size", bannerSize.toString());
break;
case "large_thumbnail":
// Use bannerSize here for slight downscaling, but larger than thumbnail
url.searchParams.set("max_size", bannerSize.toString());
break;
Copy link
Copy Markdown
Member Author

@Nutomic Nutomic May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a bug here, in large card mode it was always loading images downscaled to 512px because it was entering the default case here. Also added other variants where it seems to make sense.

Copy link
Copy Markdown
Member

@dessalines dessalines May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm... not sure about this one. 512px seems plenty large enough, and we def want to downscale no matter, even for the card views, to save on initial page load bandwidth. These images could be 10MB or more, we don't know.

The only time we shouldn't be downscaling IMO, is for the full image viewer.

Copy link
Copy Markdown
Member Author

@Nutomic Nutomic May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay changed the name to large_thumbnail and set it to 2048px.

default:
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/post/post-listing-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ function PostImg({
<div className="my-2">
<PictrsImage
src={imageSrc}
type="full_size"
type="large_thumbnail"
alt={post.alt_text}
imageDetails={postView.image_details}
nsfw={postView.post.nsfw || postView.community.nsfw}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/post/post-listings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,6 @@ function postListingModeCols(mode: PostListingMode): string {
return "col-12";
case "card":
case "small_card":
return "col-12 col-md-6";
return "col-12 col-xl-6";
}
}