audit11: full post-audit re-review (PASS) + PoCs#17
Open
77ph wants to merge 1 commit into
Open
Conversation
Complete manual re-review of all L1/L2 contracts at the post-audit merge commit. Verdict PASS (0 Critical / 0 High / 0 Medium): one low-severity fee-model observation (L-1: external-staking V1 rewards can be taxed twice by the ESD split plus Collector.protocolFactor) and one hardening note (I-1: MultisigGuard does not constrain the service-multisig token balance, confirmed non-exploitable), plus informational observations. All prior internal (audit1-10) and external (CODESPECT) resolutions re-verified present. Two runnable PoCs under audits/audit11/poc/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full post-audit re-review of all L1/L2 contracts at the current post-audit commit.
Verdict: PASS — no exploitable vulnerabilities (0 Critical / 0 High / 0 Medium).
ExternalStakingDistributorreward split plusCollector.protocolFactorapplied again on relay), lowering the stOLAS-holder share from 80% to 72% of an external reward. Every wei stays within the protocol; the recommendation is to confirm the intended fee model. Quantified inaudits/audit11/poc/double_fee.js.MultisigGuarddoes not constrain the service-multisig token balance. Confirmed non-exploitable — the external staking proxies gate claim/unstake to theExternalStakingDistributor, so rewards are distributed atomically and leave ~0 on the Safe (seeaudits/audit11/poc/guard_balance.js). A hardening suggestion is included.audits/audit11/poc/(real Gnosis Safe + real Autonolas registries; run instructions in the poc README).Full report:
audits/audit11/README.md.