Feature/dynamic width test#551
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements dynamic table width functionality, allowing tables to be resized horizontally while maintaining proper layout and positioning. The feature adds interactive resize handles to tables and updates all related calculations to use dynamic widths instead of fixed values.
- Replaced fixed
TABLE_WIDTHconstant withDEFAULT_TABLE_WIDTHas a fallback value - Added table resize functionality with left and right resize handles
- Updated all width calculations throughout the codebase to support dynamic table widths
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pods/toolbar/components/export-button/export-coordinate.helpers.ts | Updated table width calculation to use dynamic width with fallback |
| src/pods/toolbar/components/export-button/export-button.component.tsx | Refactored export logic to support dynamic table widths and canvas sizing |
| src/pods/toolbar/components/export-button/export-button.business.ts | Added new functions for dynamic width calculations and table normalization |
| src/pods/toolbar/components/export-button/export-button.business.spec.ts | Updated test constants to use DEFAULT_TABLE_WIDTH |
| src/pods/export/components/table/database-table.component.tsx | Modified table rendering to support dynamic widths |
| src/pods/export/components/table/database-table-row.component.tsx | Updated row rendering with dynamic width calculations |
| src/pods/export/components/relation/components/database-relation-self-export.component.tsx | Updated self-relation path calculations |
| src/pods/edit-table/edit-table.vm.ts | Added width property to TableVm interface |
| src/pods/canvas/components/table/table-resize.hook.ts | New hook implementing table resize functionality |
| src/pods/canvas/components/table/database-table.module.css | Added CSS styles for resize handles |
| src/pods/canvas/components/table/database-table.component.tsx | Integrated resize functionality into table component |
| src/pods/canvas/components/table/database-table-render-rows.helper.tsx | Updated row rendering helper to pass table width |
| src/pods/canvas/components/table/components/table-resize-handles.component.tsx | New component for resize handles |
| src/pods/canvas/components/table/components/database-table-row.component.tsx | Updated row component with dynamic width calculations and debug logging |
| src/pods/canvas/components/table/components/database-table-header.component.tsx | Updated header component to use dynamic width |
| src/pods/canvas/components/table/components/database-table-border.component.tsx | Updated border component to use dynamic width |
| Multiple relation components | Updated relation path calculations to support dynamic table widths |
| src/core/providers/canvas-schema/canvas.const.ts | Removed TABLE_WIDTH constant, keeping only DEFAULT_TABLE_WIDTH |
| src/core/providers/canvas-schema/canvas.business.ts | Updated coordinate calculations to use dynamic widths |
| src/core/providers/canvas-schema/canvas-schema.provider.tsx | Added updateTableWidth function to context |
| src/core/providers/canvas-schema/canvas-schema-vlatest.model.ts | Added width property to TableVm and context interfaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
….component.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.