Skip to content

Commit e8d7a03

Browse files
authored
Merge pull request SeemSeam#128 from Erick-Abe-git/main
fix(test): correct _NoopThread mock in test_worker_pool.py
2 parents 57a29b5 + fc4f939 commit e8d7a03

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

test/test_worker_pool.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ class _NoopThread(threading.Thread):
1212
def __init__(self, session_key: str, started: list[str]):
1313
super().__init__(daemon=True)
1414
self.session_key = session_key
15-
self._started = started
15+
self._track = started # avoid overriding threading.Thread._started
1616

1717
def start(self) -> None: # type: ignore[override]
18-
self._started.append(self.session_key)
18+
self._track.append(self.session_key)
19+
# Mark as "alive" by setting _started event (required for is_alive() check)
20+
self._started.set()
1921

2022

2123
def test_per_session_worker_pool_reuses_same_key() -> None:

0 commit comments

Comments
 (0)