fix: ux + logs sse

Leoglme · Leoglme · commit e85f79784aa9 · 2026-04-20T19:20:06.000+02:00
diff --git a/.github/workflows/deploy-api.yml b/.github/workflows/deploy-api.yml
@@ -177,7 +177,7 @@ jobs:
             WorkingDirectory=${APP_ROOT}
             EnvironmentFile=${APP_ROOT}/.env
             # Affichage virtuel : Chromium avec VINTED_BROWSER_HEADLESS=false a besoin d'un DISPLAY (xauth requis pour xvfb-run).
-            ExecStart=/usr/bin/xvfb-run -a --server-args="-screen 0 1920x1080x24" ${APP_ROOT}/.venv/bin/uvicorn main:app --host 127.0.0.1 --port ${PORT} --workers 2 --proxy-headers
+            ExecStart=/usr/bin/xvfb-run -a --server-args="-screen 0 1920x1080x24" ${APP_ROOT}/.venv/bin/uvicorn main:app --host 127.0.0.1 --port ${PORT} --workers 1 --proxy-headers
             Restart=always
             RestartSec=5
 
diff --git a/api/routes/articles.py b/api/routes/articles.py
@@ -216,12 +216,12 @@ def start_ebay_batch(
                 detail=f"Article {aid} needs at least one HTTPS image for eBay.",
             )
 
-    # Enregistre les canaux SSE **avant** de retourner 202 : `BackgroundTasks`
-    # ne démarre qu'après l'envoi de la réponse, et le front ouvre
-    # `GET /articles/{id}/listing-progress` dès réception → sans ces registers
-    # upfront, l'ouverture du SSE gagne la course et on renvoie l'erreur
-    # « Aucune session de publication pour cet article. » alors que la publication
-    # va en fait se dérouler juste après sans logs visibles côté UI.
+    # Register SSE channels **before** returning 202: FastAPI `BackgroundTasks`
+    # only start after the response is sent, and the front-end opens
+    # `GET /articles/{id}/listing-progress` as soon as it gets the response →
+    # without these upfront registers, the SSE wins the race and we reply with
+    # "Aucune session de publication pour cet article." even though the publish
+    # is about to run right after, with no logs visible in the UI.
     for aid in unique_ids:
         vinted_progress_hub.register(aid)
 
diff --git a/api/services/ebay_oauth_service.py b/api/services/ebay_oauth_service.py
@@ -22,7 +22,7 @@
 
 
 class EbayOAuthError(RuntimeError):
-    """Erreur OAuth eBay exploitable côté UI (code + message lisibles)."""
+    """User-facing eBay OAuth error (stable code + human-readable message)."""
 
     def __init__(self, code: str, message: str, *, status: int | None = None) -> None:
         super().__init__(code)
@@ -35,8 +35,9 @@ def __str__(self) -> str:
 
 
 def _describe_ebay_oauth_error(status: int, body: str) -> EbayOAuthError:
-    """Transforme un body 4xx eBay (`{"error": "...", "error_description": "..."}`)
-    en exception `RuntimeError` lisible, avec un code applicatif stable pour l'UI."""
+    """Turn an eBay 4xx body (`{"error": "...", "error_description": "..."}`)
+    into a readable `RuntimeError` with a stable application code for the UI.
+    User-facing messages are kept in French (shown verbatim in the app UI)."""
     payload: dict[str, Any] = {}
     try:
         parsed = json.loads(body) if body else {}
@@ -135,15 +136,14 @@ async def exchange_authorization_code(code: str, *, app: AppSettings | None = No
 
 
 async def refresh_user_access_token(refresh_token: str, *, app: AppSettings | None = None) -> dict[str, Any]:
-    """Rafraîchit l'access token utilisateur.
-
-    On ne force **volontairement pas** le paramètre ``scope`` : eBay renvoie alors
-    un token portant les scopes tels qu'ils ont été consentis au moment de la
-    connexion. C'est indispensable quand ``EBAY_SCOPES`` évolue (ajout de
-    ``sell.fulfillment`` par exemple) : les utilisateurs déjà connectés avant
-    l'ajout continuent de publier (inventory + account) sans reconsentement ;
-    les fonctionnalités nécessitant le nouveau scope détecteront son absence et
-    proposeront la reconnexion.
+    """Refresh the user access token.
+
+    We intentionally do **not** send the ``scope`` parameter: eBay then returns
+    a token with the scopes as originally consented. This is required when
+    ``EBAY_SCOPES`` evolves (e.g. when ``sell.fulfillment`` was added): users
+    already connected before the change keep publishing (inventory + account)
+    without re-consenting; features that need the new scope detect its absence
+    and prompt the user to reconnect.
     """
     s = app or get_settings()
     if not ebay_oauth_configured(s):
diff --git a/api/services/ebay_publish_service.py b/api/services/ebay_publish_service.py
@@ -286,10 +286,10 @@ async def publish_article_to_ebay(
         await _emit_ebay(progress, "auth", "Connecting to the eBay API…")
         token = await ensure_ebay_access_token(db, user, app=s)
     except Exception as exc:
-        # Inclut RuntimeError (ebay_not_connected, ebay_oauth_not_configured, …)
-        # et EbayOAuthError (invalid_scope, invalid_grant, …). On ne laisse plus
-        # fuir httpx.HTTPStatusError : le log « auth → error » doit toujours être
-        # émis pour que le Journal des publications affiche la vraie raison.
+        # Covers RuntimeError (ebay_not_connected, ebay_oauth_not_configured, …)
+        # and EbayOAuthError (invalid_scope, invalid_grant, …). We must not let
+        # httpx.HTTPStatusError escape: the "auth → error" log has to be emitted
+        # so the publish journal always shows the real reason.
         logger.warning("eBay token acquisition failed for user=%s: %s", user.id, exc)
         detail = str(exc) or exc.__class__.__name__
         await _emit_ebay(progress, "error", "Could not obtain an eBay token.", detail=detail)
diff --git a/api/services/vinted_progress_session_service.py b/api/services/vinted_progress_session_service.py
@@ -80,11 +80,11 @@ async def finish(cls, article_id: int, payload: dict[str, Any]) -> None:
 
     @classmethod
     async def event_stream(cls, article_id: int) -> AsyncIterator[dict[str, Any]]:
-        # Petit filet de sécurité : si une route a enregistré la session via
-        # `BackgroundTasks` (donc après le retour HTTP) ou si le front ouvre le
-        # SSE très vite après un POST 202, on laisse jusqu'à ~1,5 s pour que
-        # `register()` soit appelé. Au-delà on considère qu'il n'y a vraiment
-        # pas de publication en cours pour cet article.
+        # Small safety net: if a route registers the session via
+        # `BackgroundTasks` (i.e. after the HTTP response) or if the front opens
+        # the SSE right after a 202, allow up to ~1.5s for `register()` to be
+        # called. After that we consider that no publish is actually running
+        # for this article.
         s = cls._sessions.get(article_id)
         if s is None:
             for _ in range(15):
diff --git a/web/app/components/DesktopUpdaterPanel.vue b/web/app/components/DesktopUpdaterPanel.vue
@@ -104,17 +104,17 @@ async function installUpdate() {
     errorMessage.value = null
     resetDownloadProgress()
 
-    // Sur Windows, l'installeur NSIS réécrit `goupix-vinted-worker.exe` :
-    // il faut impérativement tuer le sidecar (et ses enfants Chromium lancés
-    // par nodriver) AVANT, sinon l'install échoue avec « Error opening file
-    // for writing ». Le kill côté Rust propage un taskkill /F /T sur l'arbre.
+    // On Windows, the NSIS installer overwrites `goupix-vinted-worker.exe`:
+    // the sidecar (and its Chromium children spawned by nodriver) must be
+    // killed BEFORE, otherwise the install fails with "Error opening file for
+    // writing". The Rust side runs a `taskkill /F /T` on the whole tree.
     try {
       await invoke('stop_local_worker')
     } catch (killError) {
-      console.warn('[Updater] stop_local_worker a échoué, on tente quand même l\'install :', killError)
+      console.warn('[Updater] stop_local_worker failed, proceeding with install anyway:', killError)
     }
-    // Laisse Windows libérer les handles sur le .exe et ses DLLs avant que
-    // NSIS ne commence l'extraction.
+    // Give Windows a moment to release handles on the .exe and its DLLs
+    // before NSIS starts extracting.
     await new Promise((resolve) => setTimeout(resolve, 600))
 
     await pendingUpdate.value.downloadAndInstall(onDownloadEvent)
diff --git a/web/app/components/articles/ArticleList.vue b/web/app/components/articles/ArticleList.vue
@@ -379,7 +379,7 @@ const UAvatar = resolveComponent('UAvatar')
 
     <div
       v-if="selectedCount > 0"
-      class="flex flex-col gap-2 rounded-lg border border-default bg-elevated/60 px-3 py-2.5 sm:flex-row sm:flex-wrap sm:items-center sm:justify-between"
+      class="sticky top-0 z-30 flex flex-col gap-2 rounded-lg border border-default bg-elevated/95 px-3 py-2.5 shadow-md shadow-black/5 backdrop-blur supports-[backdrop-filter]:bg-elevated/85 sm:flex-row sm:flex-wrap sm:items-center sm:justify-between"
     >
       <p class="text-sm text-highlighted">
         {{ selectedCount }} article{{ selectedCount > 1 ? 's' : '' }} sélectionné{{ selectedCount > 1 ? 's' : '' }}
@@ -445,7 +445,7 @@ const UAvatar = resolveComponent('UAvatar')
       <table class="min-w-full text-sm border-separate border-spacing-0">
         <thead class="bg-elevated/60 text-left text-muted uppercase text-xs">
           <tr>
-            <th class="w-10 px-3 py-2 font-medium align-middle border-b border-default">
+            <th class="sticky left-0 z-20 w-10 px-3 py-2 font-medium align-middle border-b border-r border-default bg-elevated">
               <UCheckbox
                 :model-value="allFilteredSelected"
                 :indeterminate="someFilteredSelected && !allFilteredSelected"
@@ -502,9 +502,9 @@ const UAvatar = resolveComponent('UAvatar')
           <tr
             v-for="row in filtered"
             :key="row.id"
-            class="border-t border-default hover:bg-elevated/40"
+            class="group border-t border-default hover:bg-elevated/40"
           >
-            <td class="px-3 py-3 align-middle border-b border-default">
+            <td class="sticky left-0 z-10 px-3 py-3 align-middle border-b border-r border-default bg-default transition-colors group-hover:bg-elevated/40">
               <UCheckbox
                 :model-value="isSelected(row.id)"
                 :aria-label="`Sélectionner ${row.pokemon_name || row.title}`"
diff --git a/web/app/composables/useVintedPublishStream.ts b/web/app/composables/useVintedPublishStream.ts
@@ -113,8 +113,8 @@ export function useVintedPublishStream() {
             const v = data.vinted
             const eb = data.ebay
             if (context === 'logs') {
-              // Journal des publications : on matérialise les échecs dans la
-              // liste de logs (sinon l'utilisateur ne voit qu'un `done` muet).
+              // Publish journal: surface failures as log entries (otherwise
+              // the user only sees a silent `done`).
               if (v && v.published === false) {
                 const detail
                   = v.detail === 'missing_vinted_credentials'
diff --git a/web/src-tauri/nsis-hooks.nsh b/web/src-tauri/nsis-hooks.nsh
@@ -1,19 +1,19 @@
-; Hooks NSIS personnalisés pour le bundle Tauri Windows.
+; Custom NSIS hooks for the Tauri Windows bundle.
 ;
-; Contexte : GoupixDex embarque un sidecar PyInstaller `goupix-vinted-worker.exe`
-; qui lance lui-même Chromium via nodriver. Pendant une mise à jour, NSIS doit
-; réécrire ce .exe ; s'il est encore en mémoire (ou si un des Chromium enfants
-; garde un handle), l'install échoue avec :
-;   « Error opening file for writing: ...\goupix-vinted-worker.exe »
+; GoupixDex ships a PyInstaller sidecar `goupix-vinted-worker.exe` that itself
+; spawns Chromium through nodriver. During an update NSIS needs to overwrite
+; that .exe; if it (or one of its Chromium children) still holds a handle the
+; install fails with:
+;   "Error opening file for writing: ...\goupix-vinted-worker.exe"
 ;
-; Côté app Tauri on appelle déjà la commande `stop_local_worker` avant
-; `downloadAndInstall`, mais ce hook joue le rôle de filet de sécurité
-; (install manuel depuis GitHub Releases, app crashée, anciens orphelins...).
+; The Tauri app already calls the `stop_local_worker` command before
+; `downloadAndInstall`, but this hook is the safety net (manual install from
+; GitHub Releases, crashed app, leftover orphans, ...).
 
 !macro NSIS_HOOK_PREINSTALL
-  DetailPrint "Arrêt du worker GoupixDex s'il est en cours d'exécution..."
-  ; /F = force, /T = tue aussi l'arborescence (Chromium lancés par nodriver).
-  ; On redirige la sortie vers nul pour rester silencieux si aucun process n'est trouvé.
+  DetailPrint "Stopping GoupixDex worker if it is still running..."
+  ; /F = force, /T = kill the whole tree (Chromium spawned by nodriver).
+  ; Output redirected to nul so the installer stays silent if no process exists.
   nsExec::Exec 'cmd /C taskkill /F /T /IM goupix-vinted-worker.exe >nul 2>&1'
   Pop $0
   Sleep 500
diff --git a/web/src-tauri/src/lib.rs b/web/src-tauri/src/lib.rs
@@ -127,10 +127,9 @@ fn check_browser_availability() -> BrowserInfo {
 #[cfg(target_os = "windows")]
 const CREATE_NO_WINDOW: u32 = 0x0800_0000;
 
-/// Tue le worker local et toute son arborescence de sous-processus (Chromium
-/// lancés par nodriver notamment). Indispensable avant un remplacement sur
-/// disque de `goupix-vinted-worker.exe` (mise à jour NSIS) pour ne pas se
-/// retrouver avec un fichier verrouillé.
+/// Kill the local worker and its whole child process tree (Chromium spawned by
+/// nodriver in particular). Required before overwriting
+/// `goupix-vinted-worker.exe` on disk (NSIS update) to avoid a locked file.
 fn kill_worker_tree(child: CommandChild) {
     #[cfg(target_os = "windows")]
     {
@@ -143,8 +142,8 @@ fn kill_worker_tree(child: CommandChild) {
     let _ = child.kill();
 }
 
-/// Commande exposée au front-end pour fermer proprement le worker avant une
-/// mise à jour Tauri (voir `DesktopUpdaterPanel.vue`).
+/// Tauri command called from the front-end to shut the worker down cleanly
+/// before a Tauri update (see `DesktopUpdaterPanel.vue`).
 #[tauri::command]
 fn stop_local_worker(state: tauri::State<'_, VintedLocalChild>) -> Result<(), String> {
     let child_opt = match state.0.lock() {
