Restore xml children order#442
Open
j3k0 wants to merge 5 commits into
Open
Conversation
Quite a refactoring the Builder class. It is now a 2 steps process: 1. Preprocessing Convert nodes to a unified format. In this format, children are extracted as an array, then sorted by their position in the original XML document (if made available using the `sourcemap` option). 2. XML building The code here has been simplified as special cases are handled at processing stage. It build the XML.
2 similar comments
|
@j3k0 This is brilliant. |
|
@j3k0 Amazin PR, waiting for it to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #440
This PR uses
$sourceto restore the original XML nodes order.Quite a refactoring the Builder class. It is now a 2 steps process:
Step 1. Preprocessing
Convert "json" nodes to a unified format.
In this format, children are extracted as an array, then sorted by their position in the original XML document (if made available during parsing, using the
sourcemapoption).Step 2. XML building
The code here has been simplified as special cases are handled at preprocessing stage. It build the XML.
Also makes sure source map doesn't show up in the exported XML