refactor: 修改编码和解码函数以返回状态

Author: LessUp

algorithms/huffman/cpp/main.cpp

@@ -343,12 +343,12 @@ static bool decompress_file(const std::string& input_path, const std::string& ou
     return ok;
 }
 
-void huffman_encode_file(const std::string& input_path, const std::string& output_path) {
-    (void)compress_file(input_path, output_path);
+bool huffman_encode_file(const std::string& input_path, const std::string& output_path) {
+    return compress_file(input_path, output_path);
 }
 
-void huffman_decode_file(const std::string& input_path, const std::string& output_path) {
-    (void)decompress_file(input_path, output_path);
+bool huffman_decode_file(const std::string& input_path, const std::string& output_path) {
+    return decompress_file(input_path, output_path);
 }
 
 int main(int argc, char** argv) {

algorithms/huffman/go/huffman.go

@@ -174,15 +174,13 @@ func BuildFrequenciesFromFile(path string) ([]uint32, error) {
 	freq := make([]uint32, SymbolLimit)
 	f, err := os.Open(path)
 	if err != nil {
-		freq[EOFSymbol] = 1
-		return freq, nil
+		return nil, fmt.Errorf("cannot open input file: %s: %w", path, err)
 	}
 	defer f.Close()
 
 	stat, err := f.Stat()
 	if err != nil {
-		freq[EOFSymbol] = 1
-		return freq, nil
+		return nil, fmt.Errorf("cannot stat input file: %s: %w", path, err)
 	}
 	if stat.Size() > MaxInputSize {
 		return nil, fmt.Errorf("input file too large (max %d bytes)", MaxInputSize)
@@ -349,7 +347,7 @@ func Decode(r io.Reader, w io.Writer) error {
 			}
 			node = root
 		}
-		if bitReader.EOF() && node.IsLeaf() == false && node.Left == nil && node.Right == nil {
+		if bitReader.EOF() && node == root {
 			break
 		}
 	}

algorithms/rle/cpp/main.cpp

@@ -52,8 +52,8 @@ static bool read_u32_le(std::istream& in, uint32_t& out_value) {
 static bool rle_encode_file_checked(const std::string& input_path, const std::string& output_path);
 static bool rle_decode_file_checked(const std::string& input_path, const std::string& output_path);
 
-void rle_encode_file(const std::string& input_path, const std::string& output_path) {
-    (void)rle_encode_file_checked(input_path, output_path);
+bool rle_encode_file(const std::string& input_path, const std::string& output_path) {
+    return rle_encode_file_checked(input_path, output_path);
 }
 
 // Perform Run-Length encoding on entire file.
@@ -170,8 +170,8 @@ static bool rle_decode_file_checked(const std::string& input_path, const std::st
     return true;
 }
 
-void rle_decode_file(const std::string& input_path, const std::string& output_path) {
-    (void)rle_decode_file_checked(input_path, output_path);
+bool rle_decode_file(const std::string& input_path, const std::string& output_path) {
+    return rle_decode_file_checked(input_path, output_path);
 }
 
 int main(int argc, char** argv) {