fix: 修复代码审查发现的潜在 bug

- wsClient: WebSocket onerror 返回 Error 对象而非原始 Event
- digitalHumanStore: setExpressionIntensity 处理 NaN 输入
- chatTransport: emotion 类型添加运行时白名单验证
- useTheme/i18n: localStorage 操作添加 try-catch 保护

Author: LessUp

src/core/dialogue/chatTransport.ts

@@ -40,6 +40,14 @@ export interface ChatTransportCapabilities {
 
 const DEFAULT_TIMEOUT_MS = 15000;
 
+const VALID_EMOTIONS = ['neutral', 'happy', 'surprised', 'sad', 'angry'] as const;
+
+const validateEmotion = (emotion: string): ChatResponsePayload['emotion'] => {
+  return VALID_EMOTIONS.includes(emotion as (typeof VALID_EMOTIONS)[number])
+    ? (emotion as ChatResponsePayload['emotion'])
+    : 'neutral';
+};
+
 const buildEmptyResponse = (): ChatResponsePayload => ({
   replyText: '',
   emotion: 'neutral',
@@ -132,7 +140,7 @@ async function* streamOverWebSocket(
     if (event.type === 'done') {
       callbacks.onDone?.({
         replyText: event.replyText,
-        emotion: event.emotion as ChatResponsePayload['emotion'],
+        emotion: validateEmotion(event.emotion),
         action: event.action,
       });
       setTerminalEvent(event);
@@ -187,7 +195,7 @@ async function* streamOverWebSocket(
       return {
         response: {
           replyText: terminal.replyText,
-          emotion: terminal.emotion as ChatResponsePayload['emotion'],
+          emotion: validateEmotion(terminal.emotion),
           action: terminal.action,
         },
         connectionStatus: 'connected' as const,

src/core/dialogue/wsClient.ts

@@ -105,10 +105,9 @@ export class MetaHumanWSClient {
         }
       };
 
-      this.ws.onerror = (event) => {
-
+      this.ws.onerror = () => {
         this.rejectConnect = null;
-        reject(event);
+        reject(new Error('WebSocket 连接失败'));
       };
 
       this.ws.onclose = () => {
@@ -136,7 +135,6 @@ export class MetaHumanWSClient {
     if (this.rejectConnect) {
       this.rejectConnect(new Error('WebSocket disconnected'));
       this.rejectConnect = null;
-
     }
     this.ws?.close();
     this.ws = null;

src/hooks/useTheme.ts

@@ -12,18 +12,34 @@ function resolveTheme(theme: Theme): ResolvedTheme {
   return theme === 'system' ? getSystemTheme() : theme;
 }
 
+function getStoredTheme(): Theme {
+  try {
+    return (localStorage.getItem('theme') as Theme) || 'system';
+  } catch {
+    return 'system';
+  }
+}
+
+function setStoredTheme(theme: Theme): void {
+  try {
+    localStorage.setItem('theme', theme);
+  } catch {
+    // Ignore storage write failures
+  }
+}
+
 export function useTheme() {
   const [theme, setThemeState] = useState<Theme>(() => {
     if (typeof window === 'undefined') return 'system';
-    return (localStorage.getItem('theme') as Theme) || 'system';
+    return getStoredTheme();
   });
 
   const resolved = resolveTheme(theme);
 
   useEffect(() => {
     document.documentElement.classList.remove('light', 'dark');
     document.documentElement.classList.add(resolved);
-    localStorage.setItem('theme', theme);
+    setStoredTheme(theme);
   }, [theme, resolved]);
 
   useEffect(() => {

src/lib/i18n.ts

@@ -247,8 +247,12 @@ export function getCurrentLanguage(): Language {
   if (urlLang === 'zh') return 'zh-CN';
 
   // 2. localStorage（用户偏好）
-  const stored = localStorage.getItem('preferred-lang') as Language | null;
-  if (stored === 'en' || stored === 'zh-CN') return stored;
+  try {
+    const stored = localStorage.getItem('preferred-lang') as Language | null;
+    if (stored === 'en' || stored === 'zh-CN') return stored;
+  } catch {
+    // Ignore storage read failures
+  }
 
   // 3. 浏览器语言
   const browserLang = navigator.language || '';
@@ -260,7 +264,11 @@ export function getCurrentLanguage(): Language {
 
 // 设置语言
 export function setLanguage(lang: Language): void {
-  localStorage.setItem('preferred-lang', lang);
+  try {
+    localStorage.setItem('preferred-lang', lang);
+  } catch {
+    // Ignore storage write failures
+  }
   document.documentElement.lang = lang;
   document.documentElement.setAttribute('data-lang', lang);
 

src/store/digitalHumanStore.ts

@@ -118,7 +118,7 @@ export const useDigitalHumanStore = create<DigitalHumanState>()(
       setEmotion: (emotion) => set({ currentEmotion: emotion }),
       setExpression: (expression) => set({ currentExpression: expression }),
       setExpressionIntensity: (intensity) =>
-        set({ expressionIntensity: Math.max(0, Math.min(1, intensity)) }),
+        set({ expressionIntensity: Math.max(0, Math.min(1, intensity || 0)) }),
       setBehavior: (behavior) => set({ currentBehavior: behavior }),
 
       // 控制方法