Skip to content

fix #539: address vulnerabilities with npm audit fix#540

Open
mathematiCode wants to merge 7 commits intodevelopfrom
Julianna/539-Address-Vulnerabilities
Open

fix #539: address vulnerabilities with npm audit fix#540
mathematiCode wants to merge 7 commits intodevelopfrom
Julianna/539-Address-Vulnerabilities

Conversation

@mathematiCode
Copy link
Copy Markdown
Contributor

Description

Addresses 3 vulnerabilities that came up using npm audit fix.

Before:

image

After:

Closes #539

Testing instructions

run npm audit in the terminal

Pre-submission checklist

✅ Code builds and passes locally
✅ PR title follows Conventional Commit format (e.g. test #001: created unit test for __ component)
❓ Request reviews from the Peer Code Reviewers and Senior+ Code Reviewers groups
✅ Thread has been created in Discord and PR is linked in gis-code-questions

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elecretanta Ready Ready Preview Comment Sep 11, 2025 9:42pm
elecretanta-storybook Ready Ready Preview Comment Sep 11, 2025 9:42pm
elecretanta-unit-test Error Error Sep 11, 2025 9:42pm

@shashilo shashilo requested review from a team July 2, 2025 19:24
@nickytonline
Copy link
Copy Markdown
Member

To be honest npm audit fix isn't that great. I even talked again recently to one of the people that worked on this for npm who basically said that. 😅 We're better off with Dependabot udpates configured in the project that run say weekly. I don't have access to the project settings, so I can't say if we have that configured or not.

nickytonline
nickytonline previously approved these changes Jul 4, 2025
Copy link
Copy Markdown
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased. Assuming the project builds and tests are passing, this is probably good to go, but as mentioned, Dependabot running on the project is the route to go for dependency updates.

bethanyann
bethanyann previously approved these changes Jul 7, 2025
@mathematiCode mathematiCode dismissed stale reviews from nickytonline and bethanyann via 2a2711b July 8, 2025 16:25
@shashilo shashilo requested review from a team and removed request for a team July 8, 2025 16:26
@nickytonline
Copy link
Copy Markdown
Member

@mathematiCode, you mentioned in Discord:

I didn't run npm audit fix --force to update the Next JS version yet because I wasn't sure if that was okay to do. Do you think I should do that and then you both re-approve or just leave it as is?

Just wondering what the package-lock.json changes are is all.

@nickytonline
Copy link
Copy Markdown
Member

One thing I'd suggest as npm audit causes a lot of noise, is if we don't already have it in place in the project, consider adding Dependabot to do weekly updates of packages. cc: @shashilo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: address vulnerabilities in npm audit

4 participants