fix #539: address vulnerabilities with npm audit fix#540
fix #539: address vulnerabilities with npm audit fix#540mathematiCode wants to merge 7 commits intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
To be honest npm audit fix isn't that great. I even talked again recently to one of the people that worked on this for npm who basically said that. 😅 We're better off with Dependabot udpates configured in the project that run say weekly. I don't have access to the project settings, so I can't say if we have that configured or not. |
nickytonline
left a comment
There was a problem hiding this comment.
This needs to be rebased. Assuming the project builds and tests are passing, this is probably good to go, but as mentioned, Dependabot running on the project is the route to go for dependency updates.
version
….com/LetsGetTechnical/elecretanta into Julianna/539-Address-Vulnerabilities
2a2711b
This reverts commit 2de840b.
|
@mathematiCode, you mentioned in Discord:
Just wondering what the package-lock.json changes are is all. |
|
One thing I'd suggest as npm audit causes a lot of noise, is if we don't already have it in place in the project, consider adding Dependabot to do weekly updates of packages. cc: @shashilo |
Description
Addresses 3 vulnerabilities that came up using npm audit fix.
Before:
After:
Closes #539
Testing instructions
run
npm auditin the terminalPre-submission checklist
✅ Code builds and passes locally
✅ PR title follows Conventional Commit format (e.g.
test #001: created unit test for __ component)❓ Request reviews from the
Peer Code ReviewersandSenior+ Code Reviewersgroups✅ Thread has been created in Discord and PR is linked in
gis-code-questions