Skip to content

Commit 2d19033

Browse files
jh-488jh-488
committed
fix git input crash on win
1 parent 1b8afc7 commit 2d19033

12 files changed

Lines changed: 42 additions & 31 deletions

File tree

‎dist/index.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/server/public/app.js‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ function initializeNumberInputs() {
1919
},
2020
{ id: 'pdfScale', min: 0.1, max: 2, isInteger: false, value: 1 },
2121
{ id: 'pdfTimeout', min: 1000, max: null, isInteger: true, value: 15000 },
22+
{ id: 'docxFontSize', min: 10, max: 100, isInteger: true, value: null },
23+
{ id: 'docxTimeout', min: 1000, max: 120000, isInteger: true, value: null },
2224
]
2325

2426
numberInputs.forEach((config) => {
@@ -217,13 +219,6 @@ function initializeTabs() {
217219

218220
tab.classList.add('active')
219221
document.getElementById(`${targetTab}-panel`).classList.add('active')
220-
221-
// Clear validation states
222-
if (targetTab === 'upload') {
223-
document.getElementById('gitUrl').removeAttribute('required')
224-
} else {
225-
document.getElementById('gitUrl').setAttribute('required', 'required')
226-
}
227222
})
228223
})
229224
}

‎dist/server/public/index.html‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ <h2 data-i18n="sections.projectSource">1. Project Source</h2>
106106
type="text"
107107
id="gitUrl"
108108
name="gitUrl"
109-
placeholder="https://github.com/user/repo.git"
109+
autocomplete="off"
110+
data-i18n-placeholder="git.repoUrlPlaceholder"
111+
placeholder="github.com/user/repo"
110112
/>
111113
</div>
112114
<div class="form-row">
@@ -1315,12 +1317,11 @@ <h3 class="settings-heading" data-i18n="settings.docx.title">
13151317
>Font Size</label
13161318
>
13171319
<input
1318-
type="number"
1320+
type="text"
1321+
inputmode="numeric"
13191322
id="docxFontSize"
13201323
name="option_docx-font-size"
13211324
placeholder="22"
1322-
min="10"
1323-
max="100"
13241325
/>
13251326
<span class="hint" data-i18n="settings.docx.fontSizeHint"
13261327
>Font size in half-points (22 = 11pt)</span
@@ -1412,12 +1413,11 @@ <h3 class="settings-heading" data-i18n="settings.docx.title">
14121413
>Timeout (ms)</label
14131414
>
14141415
<input
1415-
type="number"
1416+
type="text"
1417+
inputmode="numeric"
14161418
id="docxTimeout"
14171419
name="option_docx-timeout"
14181420
placeholder="15000"
1419-
min="1000"
1420-
max="120000"
14211421
/>
14221422
<span class="hint" data-i18n="settings.docx.timeoutHint"
14231423
>Wait time for complete loading (15000 = 15 seconds)</span

‎dist/server/public/locales/de.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"files.remove": "Entfernen",
1414
"git.repoUrl": "Repository-URL",
1515
"git.repoUrlRequired": "Repository-URL *",
16+
"git.repoUrlPlaceholder": "github.com/user/repo",
1617
"git.branch": "Branch / Tag",
1718
"git.branchPlaceholder": "main",
1819
"git.subdirectory": "Unterverzeichnis",

‎dist/server/public/locales/en.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"files.remove": "Remove",
1414
"git.repoUrl": "Repository URL",
1515
"git.repoUrlRequired": "Repository URL *",
16+
"git.repoUrlPlaceholder": "github.com/user/repo",
1617
"git.branch": "Branch / Tag",
1718
"git.branchPlaceholder": "main",
1819
"git.subdirectory": "Subdirectory",

‎electron/main.js‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ function createWindow() {
3838
app.quit();
3939
});
4040

41+
// Diagnostics
42+
mainWindow.webContents.on('render-process-gone', (_e, details) => {
43+
console.error('[renderer] render-process-gone:', JSON.stringify(details));
44+
});
45+
mainWindow.webContents.on('unresponsive', () => {
46+
console.error('[renderer] became unresponsive');
47+
});
48+
mainWindow.webContents.on('did-fail-load', (_e, errorCode, errorDescription, validatedURL) => {
49+
console.error('[renderer] did-fail-load:', errorCode, errorDescription, validatedURL);
50+
});
51+
4152
mainWindow.on('closed', () => {
4253
mainWindow = null;
4354
});

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@liascript/exporter",
3-
"version": "3.3.3--1.0.10",
3+
"version": "3.3.4--1.0.10",
44
"description": "A generic exporter for LiaScript",
55
"main": "dist/index.js",
66
"repository": {

‎src/server/public/app.js‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ function initializeNumberInputs() {
1919
},
2020
{ id: 'pdfScale', min: 0.1, max: 2, isInteger: false, value: 1 },
2121
{ id: 'pdfTimeout', min: 1000, max: null, isInteger: true, value: 15000 },
22+
{ id: 'docxFontSize', min: 10, max: 100, isInteger: true, value: null },
23+
{ id: 'docxTimeout', min: 1000, max: 120000, isInteger: true, value: null },
2224
]
2325

2426
numberInputs.forEach((config) => {
@@ -217,13 +219,6 @@ function initializeTabs() {
217219

218220
tab.classList.add('active')
219221
document.getElementById(`${targetTab}-panel`).classList.add('active')
220-
221-
// Clear validation states
222-
if (targetTab === 'upload') {
223-
document.getElementById('gitUrl').removeAttribute('required')
224-
} else {
225-
document.getElementById('gitUrl').setAttribute('required', 'required')
226-
}
227222
})
228223
})
229224
}

‎src/server/public/index.html‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ <h2 data-i18n="sections.projectSource">1. Project Source</h2>
106106
type="text"
107107
id="gitUrl"
108108
name="gitUrl"
109-
placeholder="https://github.com/user/repo.git"
109+
autocomplete="off"
110+
data-i18n-placeholder="git.repoUrlPlaceholder"
111+
placeholder="github.com/user/repo"
110112
/>
111113
</div>
112114
<div class="form-row">
@@ -1315,12 +1317,11 @@ <h3 class="settings-heading" data-i18n="settings.docx.title">
13151317
>Font Size</label
13161318
>
13171319
<input
1318-
type="number"
1320+
type="text"
1321+
inputmode="numeric"
13191322
id="docxFontSize"
13201323
name="option_docx-font-size"
13211324
placeholder="22"
1322-
min="10"
1323-
max="100"
13241325
/>
13251326
<span class="hint" data-i18n="settings.docx.fontSizeHint"
13261327
>Font size in half-points (22 = 11pt)</span
@@ -1412,12 +1413,11 @@ <h3 class="settings-heading" data-i18n="settings.docx.title">
14121413
>Timeout (ms)</label
14131414
>
14141415
<input
1415-
type="number"
1416+
type="text"
1417+
inputmode="numeric"
14161418
id="docxTimeout"
14171419
name="option_docx-timeout"
14181420
placeholder="15000"
1419-
min="1000"
1420-
max="120000"
14211421
/>
14221422
<span class="hint" data-i18n="settings.docx.timeoutHint"
14231423
>Wait time for complete loading (15000 = 15 seconds)</span

‎src/server/public/locales/de.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"files.remove": "Entfernen",
1414
"git.repoUrl": "Repository-URL",
1515
"git.repoUrlRequired": "Repository-URL *",
16+
"git.repoUrlPlaceholder": "github.com/user/repo",
1617
"git.branch": "Branch / Tag",
1718
"git.branchPlaceholder": "main",
1819
"git.subdirectory": "Unterverzeichnis",

0 commit comments

Comments
 (0)