Fix snapshot auto-remove cancel behavior

Closes #2023

Author: zhaobozhen

app/src/main/kotlin/com/absinthe/libchecker/features/snapshot/ui/TimeNodeBottomSheetDialogFragment.kt

@@ -68,17 +68,35 @@ class TimeNodeBottomSheetDialogFragment : BaseBottomSheetViewDialogFragment<Time
       } else {
         root.adapter.addHeaderView(
           TimeNodeAutoRemoveView(requireContext()).also { autoRemoveView ->
+            fun recordChanged(checked: Boolean) {
+              Telemetry.recordEvent(
+                Constants.Event.SNAPSHOT_ADVANCED_MENU_ITEM_CHANGED,
+                mapOf(
+                  Telemetry.Param.CONTENT to autoRemoveView.chip.text,
+                  Telemetry.Param.VALUE to checked
+                )
+              )
+            }
+
             autoRemoveView.chip.onCheckedChangeListener = { _, checked ->
               autoRemoveView.invalidateText()
               if (checked) {
-                (context as? ContextThemeWrapper)?.let { ctw ->
-                  val dialog = UiUtils.createSnapshotAutoRemoveThresholdDialog(ctw)
-                  dialog.setOnDismissListener {
+                val ctw = context as? ContextThemeWrapper
+                if (ctw == null) {
+                  autoRemoveView.syncWithAutoRemoveThreshold()
+                } else {
+                  var confirmedThreshold: Int? = null
+                  val dialog = UiUtils.createSnapshotAutoRemoveThresholdDialog(ctw) { threshold ->
+                    confirmedThreshold = threshold
                     autoRemoveView.invalidateText()
-                    if (GlobalValues.snapshotAutoRemoveThreshold > 0) {
+                    recordChanged(true)
+                  }
+                  dialog.setOnDismissListener {
+                    autoRemoveView.syncWithAutoRemoveThreshold()
+                    confirmedThreshold?.let { threshold ->
                       lifecycleScope.launch(Dispatchers.IO) {
                         Repositories.lcRepository.retainLatestSnapshotsAndRemoveOld(
-                          count = GlobalValues.snapshotAutoRemoveThreshold,
+                          count = threshold,
                           forceShowLoading = true,
                           context = ctw
                         )
@@ -95,14 +113,9 @@ class TimeNodeBottomSheetDialogFragment : BaseBottomSheetViewDialogFragment<Time
                 }
               } else {
                 GlobalValues.snapshotAutoRemoveThreshold = -1
+                autoRemoveView.invalidateText()
+                recordChanged(false)
               }
-              Telemetry.recordEvent(
-                Constants.Event.SNAPSHOT_ADVANCED_MENU_ITEM_CHANGED,
-                mapOf(
-                  Telemetry.Param.CONTENT to autoRemoveView.chip.text,
-                  Telemetry.Param.VALUE to checked
-                )
-              )
             }
           }
         )

app/src/main/kotlin/com/absinthe/libchecker/features/snapshot/ui/view/TimeNodeAutoRemoveView.kt

@@ -37,6 +37,14 @@ class TimeNodeAutoRemoveView(context: Context) : AViewGroup(context) {
     }
   }
 
+  fun syncWithAutoRemoveThreshold() {
+    val listener = chip.onCheckedChangeListener
+    chip.onCheckedChangeListener = null
+    chip.isChecked = GlobalValues.snapshotAutoRemoveThreshold > 0
+    chip.onCheckedChangeListener = listener
+    invalidateText()
+  }
+
   override fun generateDefaultLayoutParams(): ViewGroup.LayoutParams {
     return ViewGroup.LayoutParams(
       ViewGroup.LayoutParams.MATCH_PARENT,

app/src/main/kotlin/com/absinthe/libchecker/utils/UiUtils.kt

@@ -115,10 +115,11 @@ object UiUtils {
     return drawable
   }
 
-  fun createSnapshotAutoRemoveThresholdDialog(context: ContextThemeWrapper): AlertDialog {
-    if (GlobalValues.snapshotAutoRemoveThreshold <= 0) {
-      GlobalValues.snapshotAutoRemoveThreshold = 5
-    }
+  fun createSnapshotAutoRemoveThresholdDialog(
+    context: ContextThemeWrapper,
+    onThresholdConfirmed: ((threshold: Int) -> Unit)? = null
+  ): AlertDialog {
+    val threshold = GlobalValues.snapshotAutoRemoveThreshold.takeIf { it > 0 } ?: 5
     val slider = Slider(ContextThemeWrapper(context, R.style.App_Widget_M3E_Slider)).apply {
       layoutParams =
         ViewGroup.MarginLayoutParams(200.dp, ViewGroup.LayoutParams.WRAP_CONTENT).also {
@@ -127,7 +128,7 @@ object UiUtils {
       stepSize = 1f
       valueFrom = 2f
       valueTo = 10f
-      value = GlobalValues.snapshotAutoRemoveThreshold.toFloat()
+      value = threshold.toFloat()
     }
     return BaseAlertDialogBuilder(context)
       .setTitle(R.string.album_item_management_snapshot_auto_remove_default_title)
@@ -140,7 +141,9 @@ object UiUtils {
       )
       .setCancelable(false)
       .setPositiveButton(android.R.string.ok) { _, _ ->
-        GlobalValues.snapshotAutoRemoveThreshold = slider.value.toInt()
+        val confirmedThreshold = slider.value.toInt()
+        GlobalValues.snapshotAutoRemoveThreshold = confirmedThreshold
+        onThresholdConfirmed?.invoke(confirmedThreshold)
       }
       .setNegativeButton(android.R.string.cancel, null)
       .create()