libvncclient: avoid Tight JPEG for deep pixel formats#707
Open
marcofortina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid requesting Tight JPEG when the client pixel format cannot safely consume 8-bit-per-channel JPEG samples.
Tight JPEG is an 8-bit RGB path. When the client format has more than 8 bits per RGB component, for example a 30-bit/10-bit-per-channel HDR format, requesting the Tight quality pseudo-encoding can make servers choose JPEG subencoding even though the negotiated client format cannot represent it losslessly and some servers cannot encode that source format as JPEG correctly.
Changes
tightencoding requests and the default encoding list.Validation
Tested with a minimal local CMake configuration:
cmake -S . -B build-695-patch \ -DWITH_EXAMPLES=OFF \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-695-patch --parallel 1 ctest --test-dir build-695-patch --output-on-failureResult:
Notes
I could not run the original WayVNC HDR setup locally, so this should still be runtime-verified against the reported 10-bit framebuffer case.
Closes #695.