libvncserver: read HTTP files in aligned chunks#711
Open
marcofortina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the HTTP file transfer chunk size described in #199.
The HTTP server used
BUF_SIZE - 1for every file read so that.vncfiles could be NUL-terminated before variable substitution. For non-.vncassets this produced 32767-byte chunks even though the static HTTP buffer is 32768 bytes.On strict-alignment ARM targets this can make the HTTP/WebSocket write path hit unaligned buffer handling when large files are sent in repeated chunks.
Changes
BUF_SIZE - 1only for.vncfiles that need NUL termination before substitutions.BUF_SIZEfor all other HTTP files, preserving the aligned 32768-byte chunk size..vncsubstitution behavior unchanged.Validation
Tested with a minimal local CMake configuration:
cmake -S . -B build-199-patch \ -DWITH_EXAMPLES=OFF \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-199-patch --parallel 1 ctest --test-dir build-199-patch --output-on-failureResult:
Notes
I do not have access to an ARM strict-alignment target for runtime validation, so this follows the issue's proposed fix while keeping the
.vncsubstitution path unchanged.Closes #199.