libvncserver: use zlib stream for Tight level zero#712
Open
marcofortina wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Tight encoding with zlib compression level 0.
With compression level 0, Tight rectangles were sent using the
rfbTightNoZlibpath or by bypassing zlib inCompressData(). That means clients received raw uncompressed bytes without a zlib wrapper. Some clients, including the ones reported in #370, expect a valid zlib stream even when the selected zlib level is 0.Changes
rfbTightNoZlibfor mono rectangles when the configured zlib level is 0.rfbTightNoZlibfor indexed rectangles when the configured zlib level is 0.rfbTightNoZlibfor full-color rectangles when the configured zlib level is 0.zlibLevel == 0fast-path inCompressData()so level 0 still goes throughdeflateInit2()/deflate()and produces a valid zlib stream.Validation
cmake -S . -B build-370 \ -DWITH_EXAMPLES=OFF \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-370 --parallel 1 ctest --test-dir build-370 --output-on-failureResult:
Notes
I did not run an interoperability smoke test with UltraVNCViewer/TightVNC. The change follows the issue report exactly and keeps level-0 zlib as uncompressed data inside a valid zlib stream.
Closes #370.