libvncclient: add FileTransfer client support#719
Open
marcofortina wants to merge 2 commits into
Open
Conversation
|
Good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds initial LibVNCClient support for the legacy UltraVNC/TightVNC-1.3.x
rfbFileTransfermessage path and provides a working client-side example.Changes
HandleFileTransfercallback torfbClient.FileTransferSend()for sending legacyrfbFileTransfermessages from LibVNCClient applications.rfbFileTransfermessages and dispatch them to the callback.examples/client/filetransfer.cwith:Validation
General build and tests:
cmake -S . -B build-83-patch \ -DWITH_EXAMPLES=ON \ -DWITH_TESTS=ON \ -DWITH_OPENSSL=OFF \ -DWITH_GNUTLS=OFF \ -DWITH_GCRYPT=OFF \ -DWITH_SDL=OFF \ -DWITH_GTK=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF \ -DWITH_XCB=OFF \ -DWITH_LIBSSHTUNNEL=OFF \ -DWITH_SYSTEMD=OFF \ -DCMAKE_BUILD_TYPE=Debug cmake --build build-83-patch --parallel 1 ctest --test-dir build-83-patch --output-on-failureResult:
Runtime smoke against the existing server-side file-transfer example:
Observed:
FileTransfer client smoke
Validated against examples/server/filetransfer with legacy TightVNC file transfer enabled:
Result: PASS.
Notes
This PR implements the legacy
rfbFileTransferclient-side path. TightVNC-2.x file transfer uses a separate protocol extension and remains out of scope for this PR.Closes #83.