Reply with RPL_SASLFAIL instead of NOTICE on invalid base64

This is consistent with Ergo, InspIRCd, Solanum, UnrealIRCd

Author: progval

sable_ircd/src/command/handlers/services/sasl.rs

@@ -6,6 +6,8 @@ use sable_network::{
 use super::*;
 use base64::prelude::*;
 
+const DEFAULT_SASL_FAIL: &str = "SASL authentication failed";
+
 #[command_handler("AUTHENTICATE")]
 async fn handle_authenticate(
     source: PreClientSource,
@@ -22,7 +24,7 @@ async fn handle_authenticate(
             RemoteServicesServerRequestType::AbortAuthenticate(*session)
         } else {
             let Ok(data) = BASE64_STANDARD.decode(text) else {
-                response.notice("Invalid base64");
+                response.numeric(make_numeric!(SaslFail, "Invalid Base64"));
                 return Ok(());
             };
 
@@ -39,7 +41,7 @@ async fn handle_authenticate(
 
         for ban in net.network_bans().find_pre_sasl(&user_details) {
             if let NetworkBanAction::DenySasl = ban.action {
-                response.numeric(make_numeric!(SaslFail));
+                response.numeric(make_numeric!(SaslFail, DEFAULT_SASL_FAIL));
                 return Ok(());
             }
         }
@@ -88,7 +90,7 @@ async fn handle_authenticate(
                     response.numeric(make_numeric!(SaslSuccess));
                 }
                 Fail => {
-                    response.numeric(make_numeric!(SaslFail));
+                    response.numeric(make_numeric!(SaslFail, DEFAULT_SASL_FAIL));
                 }
                 Aborted => {
                     response.numeric(make_numeric!(SaslAborted));
@@ -116,6 +118,6 @@ fn do_sasl_external(
         }
     }
 
-    response.numeric(make_numeric!(SaslFail));
+    response.numeric(make_numeric!(SaslFail, DEFAULT_SASL_FAIL));
     Ok(())
 }

sable_ircd/src/messages/numeric.rs

@@ -138,6 +138,6 @@ define_messages! {
 
     900(LoggedIn)           => { (account: &Nickname) => "* {account} :You are now logged in as {account}" },  // TODO: <nick>!<ident>@<host> instead of *
     903(SaslSuccess)        => { () => ":SASL authentication successful" },
-    904(SaslFail)           => { () => ":SASL authentication failed" },
+    904(SaslFail)           => { (reason: &str)                 => ":{reason}" },
     906(SaslAborted)        => { () => ":SASL authentication aborted" }
 }