refactored so that more tests use TestUtils.isExecutingOnWindows()

Author: johnscancella

src/test/java/gov/loc/repository/bagit/TestUtils.java

@@ -13,7 +13,7 @@ public static boolean isExecutingOnWindows(){
   }
 
   public static void makeFilesHiddenOnWindows(Path startingDir) throws IOException {
-    if (System.getProperty("os.name").contains("Windows")) {
+    if (isExecutingOnWindows()) {
       Files.walkFileTree(startingDir, new SimpleFileVisitor<Path>() {
         @Override
         public FileVisitResult preVisitDirectory(final Path dir, final BasicFileAttributes attrs) throws IOException{

src/test/java/gov/loc/repository/bagit/creator/AddPayloadToBagManifestVistorTest.java

@@ -15,6 +15,7 @@
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
 
+import gov.loc.repository.bagit.TestUtils;
 import gov.loc.repository.bagit.domain.Manifest;
 import gov.loc.repository.bagit.hash.StandardSupportedAlgorithms;
 
@@ -74,7 +75,7 @@ public void testSkipHiddenFile() throws IOException{
   private Path createHiddenDirectory() throws IOException{
     Path hiddenDirectory = Paths.get(folder.newFolder(".someHiddenDir").toURI());
 
-    if(System.getProperty("os.name").contains("Windows")){
+    if(TestUtils.isExecutingOnWindows()){
       Files.setAttribute(hiddenDirectory, "dos:hidden", Boolean.TRUE);
     }
 
@@ -84,7 +85,7 @@ private Path createHiddenDirectory() throws IOException{
   private Path createHiddenFile() throws IOException{
     Path hiddenDirectory = Paths.get(folder.newFile(".someHiddenFile").toURI());
 
-    if(System.getProperty("os.name").contains("Windows")){
+    if(TestUtils.isExecutingOnWindows()){
       Files.setAttribute(hiddenDirectory, "dos:hidden", Boolean.TRUE);
     }