default to old behavior of including hidden files/folders

Author: johnscancella

src/main/java/gov/loc/repository/bagit/BagFactory.java

@@ -1,14 +1,13 @@
 package gov.loc.repository.bagit;
 
+import java.io.File;
+import java.util.List;
+
 import gov.loc.repository.bagit.Bag.BagConstants;
 import gov.loc.repository.bagit.Bag.BagPartFactory;
 import gov.loc.repository.bagit.filesystem.FileSystemNodeFilter;
-import gov.loc.repository.bagit.filesystem.filter.NotHiddenFileSystemNodeFilter;
 import gov.loc.repository.bagit.impl.PreBagImpl;
 
-import java.io.File;
-import java.util.List;
-
 /**
  * <p>Provides all methods for instantiating new {@link Bag} objects, as well
  * as reading bags from disk and serializations.  You should not create a
@@ -88,7 +87,7 @@ public static Version valueOfString(String versionString) {
 	 * Creates an instance of a bag factory.
 	 */
 	public BagFactory() {
-		this.defaultNodeFilter = new NotHiddenFileSystemNodeFilter();
+		this.defaultNodeFilter = null;
 	}
 
 	public BagFactory(FileSystemNodeFilter defaultNodeFilter) {

src/main/java/gov/loc/repository/bagit/driver/CommandLineBagDriver.java

@@ -145,7 +145,7 @@ public class CommandLineBagDriver {
 	public static final String PARAM_FAIL_MODE = "failmode";
 	public static final String PARAM_COMPRESSION_LEVEL = "compressionlevel";
 	public static final String PARAM_MOVE = "move";
-	public static final String PARAM_INCLUDE_HIDDEN = "includehiddenfiles";
+	public static final String PARAM_EXCLUDE_HIDDEN = "excludehiddenfiles";
 
 	public static final String VALUE_WRITER_FILESYSTEM = Format.FILESYSTEM.name().toLowerCase();
 	public static final String VALUE_WRITER_ZIP = Format.ZIP.name().toLowerCase();
@@ -374,7 +374,7 @@ private void addOperation(String name, String help, Parameter[] params, String[]
 		jsap.registerParameter(new Switch( PARAM_HELP, JSAP.NO_SHORTFLAG, PARAM_HELP, "Prints help." ));
 		jsap.registerParameter(new Switch(PARAM_VERBOSE, JSAP.NO_SHORTFLAG, PARAM_VERBOSE, "Reports progress of the operation to the console."));
 		jsap.registerParameter(new Switch(PARAM_LOG_VERBOSE, JSAP.NO_SHORTFLAG, PARAM_LOG_VERBOSE, "Reports progress of the operation to the log."));
-        jsap.registerParameter(new Switch( PARAM_INCLUDE_HIDDEN, JSAP.NO_SHORTFLAG, PARAM_INCLUDE_HIDDEN, "Include hidden files." ));
+        jsap.registerParameter(new Switch( PARAM_EXCLUDE_HIDDEN, JSAP.NO_SHORTFLAG, PARAM_EXCLUDE_HIDDEN, "Exclude hidden files." ));
 
 		this.operationMap.put(name, new Operation(name, jsap, help, examples));
 	}
@@ -616,12 +616,11 @@ private int performOperation(Operation operation, JSAPResult config) {
 			}
 
 			BagFactory bagFactory = null;
-			if (config.getBoolean(PARAM_INCLUDE_HIDDEN)) {
+			if (config.getBoolean(PARAM_EXCLUDE_HIDDEN)) {
+				bagFactory = new BagFactory(new NotHiddenFileSystemNodeFilter());
+			} else {
 				// null filter will include all nodes, including hidden ones
 				bagFactory = new BagFactory(null);
-			} else {
-                // The default should filter out hidden files
-				bagFactory = new BagFactory(new NotHiddenFileSystemNodeFilter());
 			}
 
 			Writer writer = null;