Skip to content

Commit 40c3975

Browse files
authored
Merge pull request #48 from LibreCodeCoop/fix/actions-signing-paths
fix(actions): make app signing use absolute paths
2 parents e8307d7 + db3af19 commit 40c3975

File tree

2 files changed

+20
-12
lines changed

2 files changed

+20
-12
lines changed

.github/workflows/appstore-build-publish.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,18 @@ jobs:
122122

123123
- name: Sign app
124124
run: |
125-
printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${{ env.APP_NAME }}.key"
126-
chmod 600 "${{ env.APP_NAME }}.key"
127-
wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
125+
KEY_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.key"
126+
CERT_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.crt"
127+
APP_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"
128+
129+
printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${KEY_PATH}"
130+
chmod 600 "${KEY_PATH}"
131+
wget --quiet -O "${CERT_PATH}" "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
128132
129133
php nextcloud/occ integrity:sign-app \
130-
--privateKey="${{ env.APP_NAME }}.key" \
131-
--certificate="${{ env.APP_NAME }}.crt" \
132-
--path="${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"
134+
--privateKey="${KEY_PATH}" \
135+
--certificate="${CERT_PATH}" \
136+
--path="${APP_PATH}"
133137
134138
tar -C "${{ env.APP_NAME }}/build/artifacts" -zcf "${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}.tar.gz" "${{ env.APP_NAME }}"
135139

.github/workflows/nightly-release.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,18 @@ jobs:
152152

153153
- name: Sign app
154154
run: |
155-
printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${{ env.APP_NAME }}.key"
156-
chmod 600 "${{ env.APP_NAME }}.key"
157-
wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
155+
KEY_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.key"
156+
CERT_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}.crt"
157+
APP_PATH="${GITHUB_WORKSPACE}/${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"
158+
159+
printf '%s' '${{ secrets.APP_PRIVATE_KEY }}' > "${KEY_PATH}"
160+
chmod 600 "${KEY_PATH}"
161+
wget --quiet -O "${CERT_PATH}" "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
158162
159163
php nextcloud/occ integrity:sign-app \
160-
--privateKey="${{ env.APP_NAME }}.key" \
161-
--certificate="${{ env.APP_NAME }}.crt" \
162-
--path="${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}"
164+
--privateKey="${KEY_PATH}" \
165+
--certificate="${CERT_PATH}" \
166+
--path="${APP_PATH}"
163167
164168
tar -C "${{ env.APP_NAME }}/build/artifacts" -zcf "${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}.tar.gz" "${{ env.APP_NAME }}"
165169

0 commit comments

Comments
 (0)