Skip to content

Commit 0e699b9

Browse files
authored
Merge pull request #8915 from heitbaum/gcc14
Minor compat fixes for gcc-14.1
2 parents 738b75b + f2805be commit 0e699b9

3 files changed

Lines changed: 101 additions & 0 deletions

File tree

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
From 4e4e5736b5c69de3c68c5c02ceddfbe42eb8f915 Mon Sep 17 00:00:00 2001
2+
From: Rudi Heitbaum <rudi@heitbaum.com>
3+
Date: Wed, 22 May 2024 21:29:31 +1000
4+
Subject: [PATCH] vclog: fix compiler error with gcc-14.1
5+
6+
Fixes:
7+
8+
./vclog/vclog.c:199:30: error: 'msg.size' may be used uninitialized [-Werror=maybe-uninitialized]
9+
199 | payload_len = msg.size - sizeof(msg_hdr_t);
10+
| ~~~^~~~~
11+
./vclog/vclog.c:193:23: note: 'msg' declared here
12+
193 | msg_hdr_t msg;
13+
| ^~~
14+
---
15+
vclog/vclog.c | 1 +
16+
1 file changed, 1 insertion(+)
17+
18+
diff --git a/vclog/vclog.c b/vclog/vclog.c
19+
index 85e1366..34590fd 100644
20+
--- a/vclog/vclog.c
21+
+++ b/vclog/vclog.c
22+
@@ -194,6 +194,7 @@ int32_t main(int32_t argc, char *argv[])
23+
uint32_t payload_pos;
24+
uint32_t payload_len;
25+
26+
+ msg.size = 0;
27+
payload_pos = log_copy_wrap(log_buffer, log_size,
28+
read_pos, sizeof(msg), (char *)&msg);
29+
payload_len = msg.size - sizeof(msg_hdr_t);
Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
From dc0fd4723907775bdfc3ffb2a612a04d60789ed8 Mon Sep 17 00:00:00 2001
2+
From: Rudi Heitbaum <rudi@heitbaum.com>
3+
Date: Wed, 22 May 2024 22:04:56 +1000
4+
Subject: [PATCH] vclog: fix max realloc compiler error
5+
6+
Fixes
7+
8+
./vclog/vclog.c:211:34: error: argument 2 value '4294967288' exceeds maximum object size 2147483647 [-Werror=alloc-size-larger-than=]
9+
211 | payload_buffer = realloc(payload_buffer, payload_buffer_size);
10+
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11+
In file included from ./vclog/vclog.c:17:
12+
../../toolchain/armv7ve-libreelec-linux-gnueabihf/sysroot/usr/include/stdlib.h:683:14: note: in a call to allocation function 'realloc' declared here
13+
683 | extern void *realloc (void *__ptr, size_t __size)
14+
| ^~~~~~~
15+
---
16+
vclog/vclog.c | 3 ++-
17+
1 file changed, 2 insertions(+), 1 deletion(-)
18+
19+
diff --git a/vclog/vclog.c b/vclog/vclog.c
20+
index 85e1366..24e2b1e 100644
21+
--- a/vclog/vclog.c
22+
+++ b/vclog/vclog.c
23+
@@ -72,6 +72,7 @@ enum
24+
};
25+
26+
#define MAX(x, y) (((x) > (y)) ? (x) : (y))
27+
+#define MIN(x, y) (((x) < (y)) ? (x) : (y))
28+
#define ARRAY_SIZE(_a) (sizeof(_a)/sizeof(_a[0]))
29+
30+
#define FBIODMACOPY _IOW('z', 0x22, struct fb_dmacopy)
31+
@@ -207,7 +208,7 @@ int32_t main(int32_t argc, char *argv[])
32+
if (payload_len > payload_buffer_size)
33+
{
34+
payload_buffer_size = MAX(payload_len, 100); // skip some churn
35+
- payload_buffer = realloc(payload_buffer, payload_buffer_size);
36+
+ payload_buffer = realloc(payload_buffer, MIN(INT32_MAX, payload_buffer_size));
37+
if (!payload_buffer)
38+
die("Out of memory");
39+
}
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
From 70c7dafbd54f94a2a0f1d113cb5536ade62585fb Mon Sep 17 00:00:00 2001
2+
From: Rudi Heitbaum <rudi@heitbaum.com>
3+
Date: Wed, 22 May 2024 04:47:12 +0000
4+
Subject: [PATCH] os/access: fix pointer type mismatch
5+
6+
Fixes compile error with gcc-14.1.0
7+
8+
../os/access.c: In function 'siHostnameAddrMatch':
9+
../os/access.c:1873:27: error: assignment to 'const char **' from incompatible pointer type 'char **' [-Wincompatible-pointer-types]
10+
1873 | for (addrlist = hp->h_addr_list; *addrlist; addrlist++)
11+
| ^
12+
13+
Signed-off-by: Rudi Heitbaum rudi@heitbaum.com
14+
---
15+
os/access.c | 2 +-
16+
1 file changed, 1 insertion(+), 1 deletion(-)
17+
18+
diff --git a/os/access.c b/os/access.c
19+
index c7a2ab8c56..e694cd7925 100644
20+
--- a/os/access.c
21+
+++ b/os/access.c
22+
@@ -1882,7 +1882,7 @@ siHostnameAddrMatch(int family, void *addr, int len,
23+
if ((hp = _XGethostbyname(hostname, hparams)) != NULL) {
24+
#ifdef h_addr /* new 4.3bsd version of gethostent */
25+
/* iterate over the addresses */
26+
- for (addrlist = hp->h_addr_list; *addrlist; addrlist++)
27+
+ for (addrlist = (const char **) hp->h_addr_list; *addrlist; addrlist++)
28+
#else
29+
addrlist = &hp->h_addr;
30+
#endif
31+
--
32+
GitLab
33+

0 commit comments

Comments
 (0)