Skip to content

Shutdown crash#245

Open
ysard wants to merge 6 commits into
LibreELEC:masterfrom
ysard:shutdown_crash
Open

Shutdown crash#245
ysard wants to merge 6 commits into
LibreELEC:masterfrom
ysard:shutdown_crash

Conversation

@ysard

@ysard ysard commented Nov 4, 2021

Copy link
Copy Markdown

Hi,
I propose 2 fixes on this PR.

  • First and basically a workaround regarding a regular Kodi crash due to the Dbus Connection Object that does not seem to be deleted correctly.

This has been exposed in this issue (LibreELEC/LibreELEC.tv#5645) but there, no action has been taken so far.

The bbc7bf3 commit of the PR #240 has not solved the problem on my side.

  • Secondly, by cleanliness a fix of anecdotal typo.

Thank you for reading

Comment thread service.py Outdated
@ysard

ysard commented Nov 6, 2021

Copy link
Copy Markdown
Author

I added some minor cleaning of code; now it's finished for me.

@chewitt

chewitt commented Nov 7, 2021

Copy link
Copy Markdown
Member

Looks like the dbussy author replied to the other thread and made changes already.

@ysard

ysard commented Nov 9, 2021

Copy link
Copy Markdown
Author

I read it, the del is still needed but not the collection anymore. Still investigating...

@ysard

ysard commented Nov 11, 2021

Copy link
Copy Markdown
Author

I think that the problem is closed on the dbussy side.
I added current debugging logs on the issue LibreELEC/LibreELEC.tv#5645.

I can remove the call to garbage collector since it is not used anymore. I can also clean the commit history (via push force) of this issue if you prefer.
Nevertheless it will be necessary to wait for a new version of dbussy on pypi for this code to be compatible.

@CvH

CvH commented Dec 5, 2021

Copy link
Copy Markdown
Member

Nevertheless it will be necessary to wait for a new version of dbussy on pypi for this code to be compatible.

we bumped dbussy (LibreELEC/LibreELEC.tv#5945) so it should work now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants