Skip to content

updates.py: cleanup pass#301

Open
antonlacon wants to merge 7 commits into
LibreELEC:masterfrom
antonlacon:update-base
Open

updates.py: cleanup pass#301
antonlacon wants to merge 7 commits into
LibreELEC:masterfrom
antonlacon:update-base

Conversation

@antonlacon

Copy link
Copy Markdown
Contributor

This is a cleanup pass on updates.py. Some issues from reviewing it and some issues shown by pylint. Functional changes are converting Automatic Updates from a auto/manual selector to true/false and deleting custom channel 3. Info text for automatic updates also updated to reflect change.

The lchop/rchop changes means >=python-3.9, so no more support for LE10.

It's pulled the RPi2 LE11.0.0 -> 11.0.1 update for me. Other device testing appreciated.

@CvH

CvH commented Jun 3, 2023

Copy link
Copy Markdown
Member

@mglae can you have a look

@antonlacon
antonlacon force-pushed the update-base branch 2 times, most recently from 9899c7b to 27cecd3 Compare June 12, 2023 02:03
@antonlacon
antonlacon force-pushed the update-base branch 2 times, most recently from c1976da to c7940e2 Compare June 21, 2023 00:04
@CvH
CvH requested a review from mglae November 9, 2023 20:42
@antonlacon
antonlacon force-pushed the update-base branch 2 times, most recently from e199155 to d70b134 Compare November 18, 2023 06:46
@antonlacon
antonlacon force-pushed the update-base branch 2 times, most recently from 7f90f61 to ba5b4e6 Compare March 3, 2024 07:21
General review and cleanup of issues pointed out by pylint:

unexpected indent
could use f-strings
not inializing variables in init
redefining builtins
too broad exceptions
unneeded elses after returns
unneeded parantheses
== instead of is in evaluating True/False
unused function parameters
unused imports

Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Addon will require Python >=3.9

Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants