connman.py: Fix configuration of IPv6 Privacy Extensions#365
Open
dallmair wants to merge 1 commit into
Open
Conversation
IPv6 Privacy Extensions as defined in RFC 4941/8981 require stateless auto-configuration (SLAAC), i.e. the respective setting must be visible if and only if Method is 'auto'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPv6 Privacy Extensions as defined in RFC 4941/8981 require stateless auto-configuration (SLAAC). For other address configuration types, the respective kernel setting does not have any effect. Therefore, the Privacy setting in the LE UI should be shown if and only if Method is
auto.PS: There is actually a usability improvement possible here, but I'm not sure how to implement it best. The Privacy values mean:
disabled: No temporary IPv6 addresses assigned.enabled: Temporary IPv6 addresses assigned, but not used by default.prefered: Temporary IPv6 addresses assigned and actually used.In practice,
enabledhas the same effect asdisabledas all outgoing traffic is still sent with a persistent global unicast address (no privacy). Onlypreferedactually causes the system to send traffic with a temporary address and achieves the desired privacy effect.Thus, from a user's perspective it would be best to change this to a Boolean option where
offsetsPrivacy=disabledandonsetsPrivacy=preferedon save. On initialization,Privacy=enabledshould probably map tooff. But I'm not sure whetherenabledneeds to be retained or can be changed todisabledautomatically on save.Any thoughts and feedback is highly appreciated.