Default Type of set for Planks is Bodyweight

[hmwazir]

Prerequisites

• I am running the latest version of the app.
• I have checked the Existing Discussions and this is not a duplicate.
• I have checked the Existing Issues and this is not a duplicate.
• I have read the Contributing Guidelines.

App Version

0.2.0

Android Version & ROM

Android 16 / Pixel OS

Device Model

POCO X3 NFC

Steps to reproduce

Select plank workout anywhere.

Expected behavior

Default type of set for plank should be Duration

Actual behavior

Default Type of set for planks is Bodyweight

Screen Recording / Screenshots

No response

Crash Logs / Stack Trace

Additional info

It is also possible to do weight planks. so I think this calls for a new type of set: "Duration with Load"

[IamDg]

Hi,

Thanks for the report!

This is both a bug report and a feature request so you should consider opening different issues. Regarding the bug, as I explained in another issue #57, LibreFit dynamically assigns the type of set to exercises based on their features. As a consequence, the exercise's information is not enough to accurately determine its type of set (e.g. plank most of times is duration only, and only few people uses additional load).

The solution would be to assign the type of set directly to dataset but requires manual intervetion in a PR. As of now, the fastest workaround would be adding this type of set in the possible option of types so users can manually assign it to each of the exercises. Would this be ok?

[hmwazir]

As of now, the fastest workaround would be adding this type of set in the possible option of types so users can manually assign it to each of the exercises. Would this be ok?

Yeah sure, that works. Let me know if you want me to create a separate feature request.

The solution would be to assign the type of set directly to dataset but requires manual intervetion in a PR.

I am not very technical in this field, but I would like to know that for the solution, someone, in exercises.json, would have to add another field in each block / exercise named e.g. "allowedSetTypes", with a list of applicable values, the top one being default maybe, and that would be the most time taking work done?

[IamDg]

Yeah sure, that works. Let me know if you want me to create a separate feature request.

A separate issue would be better to track changes and let users know, thanks!

I am not very technical in this field, but I would like to know that for the solution, someone, in exercises.json, would have to add another field in each block / exercise named e.g. "allowedSetTypes", with a list of applicable values, the top one being default maybe, and that would be the most time taking work done?

Exactly, applying a new field which specifies the type of set would be the correct solution. For instance, the plank in json file looks like this:

{
    "name": "Plank",
    "force": "static",
    "level": "beginner",
    "mechanic": "isolation",
    "equipment": "body only",
    "primaryMuscles": [
      "abdominals"
    ],
    "secondaryMuscles": [],
    "instructions": [
      "Get into a prone position on the floor, supporting your weight on your toes and your forearms. Your arms are bent and directly below the shoulder.",
      "Keep your body straight at all times, and hold this position as long as possible. To increase difficulty, an arm or leg can be raised."
    ],
    "category": "strength",
    "images": [
        "Plank/0.webp",
        "Plank/1.webp"
    ],
    "id": "Plank"
  }

If there were another field (e.g., typeOfSet), it would be added to the Plank entry as:

   ...
   "force": "static",
   "typeOfSet": "duration",
   "level": "beginner",
   ...

Since this requires manual review, this approach requires some work to do correctly. The current workaround is to change the type of set persistently in the exercise's details screen (which is planned) so every time it is added to a new routine/workout, the preselected type would be applied directly without changing it every time. Thoughts?

[hmwazir]

The current workaround is to change the type of set persistently in the exercise's details screen (which is planned) so every time it is added to a new routine/workout, the preselected type would be applied directly without changing it every time.

• Does this mean that users will not have a choice other than those mentioned in the exercises details page?
• What about future proofing? E.g. if someone says there is another type of set that can be done, Will someone have to review the 900 blocks / exercises again?

[IamDg]

• Does this mean that users will not have a choice other than those mentioned in the exercises details page?
• What about future proofing? E.g. if someone says there is another type of set that can be done, Will someone have to review the 900 blocks / exercises again?

• Users will be able to choose whatever type of set they prefer. What I meant by my previous comment is that if you specify a single set type in the JSON file, LibreFit applies that set type as the default to all related exercises. However, a user can override the default at the app level on the exercise detail screen or at the workout level on the workout/routine screen.
• Most likely, yes but with each iteration there will be fewer changes, because the default set types will become progressively more accurate and suitable.