Skip to content

Removed old metric vitals form#1645

Closed
ayush0x00 wants to merge 1 commit into
LibreHealthIO:masterfrom
ayush0x00:master
Closed

Removed old metric vitals form#1645
ayush0x00 wants to merge 1 commit into
LibreHealthIO:masterfrom
ayush0x00:master

Conversation

@ayush0x00
Copy link
Copy Markdown

@ayush0x00 ayush0x00 commented Nov 21, 2020

This pr removes the deprecated old metric vitals form from the client side. Also fixed the conditional check dependent on old metric form in interface/forms_admin/forms_admin.php
This fixes the issue ibreHealthIO/lh-ehr#1626

@muarachmann
Copy link
Copy Markdown
Member

@ayush0x00 nice to see you are up to speed sending in your first contributions. A little tips

  • Ensure you highlight on what you wish to work on
  • Make sure no one else is working on it before hand to avoid unnecessary efforts and possibly conflicts - Disable Old Metric vitals Form #1629

You are welcomed to discuss in the chat or here. Closing this. Also this PR doesn't feel right at first glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants