Skip to content

Security: Fix critical path traversal (#1695) and XSS (#1693) vulnerabilities #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m4cd4r4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security: Fix critical path traversal (#1695) and XSS (#1693) vulnerabilities #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interface/billing/get_claim_file.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
$fname = $claim_file_dir . $fname;

if (!file_exists($fname)) {
echo xl("The claim file: ") . $_GET['key'] . xl(" could not be accessed.");
echo xl("The claim file: ") . htmlspecialchars($_GET['key'], ENT_QUOTES, 'UTF-8') . xl(" could not be accessed.");
}
elseif ($_GET['action'] == "print") {
?>
Expand Down
2 changes: 2 additions & 0 deletions interface/fax/fax_dispatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
else if ($_GET['scan']) {
$mode = 'scan';
$filename = $_GET['scan'];
// ensure the file variable has no illegal characters
check_file_dir_name($filename);
$filepath = $GLOBALS['scanner_output_directory'] . '/' . $filename;
}
else {
Expand Down