Skip to content

Commit 1305dd3

Browse files
refactor: centralize file extension logic in mixin
- Remove .pdf extension from envelopes (they are containers, not files) - Use metadata.extension when available for accurate file type display - Extract extension logic to fileExtension computed property in FileEntryMixin - Eliminate code duplication between FileEntry and FileEntryGrid components Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 5e768af commit 1305dd3

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

src/views/FilesList/FileEntry/FileEntry.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<FileEntryPreview :source="source" />
1515
<FileEntryName ref="name"
1616
:basename="source.name"
17-
:extension="'.pdf'" />
17+
:extension="fileExtension" />
1818
</td>
1919

2020
<!-- Actions -->

src/views/FilesList/FileEntry/FileEntryGrid.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<FileEntryPreview :source="source" />
1111
<FileEntryName ref="name"
1212
:basename="source.name"
13-
:extension="'.pdf'" />
13+
:extension="fileExtension" />
1414
</td>
1515

1616
<!-- Checkbox -->

src/views/FilesList/FileEntry/FileEntryMixin.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,13 @@ export default {
4545
color: `color-mix(in srgb, var(--color-main-text) ${ratio}%, var(--color-text-maxcontrast))`,
4646
}
4747
},
48+
49+
fileExtension() {
50+
if (this.source.nodeType === 'envelope') {
51+
return ''
52+
}
53+
return this.source.metadata?.extension ? '.' + this.source.metadata.extension : '.pdf'
54+
},
4855
},
4956
methods: {
5057
// Open the actions menu on right click

0 commit comments

Comments
 (0)