Skip to content

Commit 448c235

Browse files
refactor: implement auto-save on filter changes and remove manual save button
- Remove 'Save filter' button from FileListFilter component - Implement automatic saving when filters are selected/deselected - Add setMarkedFilter() call in watchers for auto-save behavior - Simplify filter logic by removing manual save action - Clean up debug console.log statements - Update SCSS styling to use nested syntax for reset button Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent afcf6a8 commit 448c235

3 files changed

Lines changed: 11 additions & 44 deletions

File tree

src/views/FilesList/FileListFilter/FileListFilter.vue

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@
1818
@click="$emit('reset-filter')">
1919
{{ t('files', 'Clear filter') }}
2020
</NcActionButton>
21-
<NcActionButton close-after-click
22-
@click="$emit('set-marked-filter')">
23-
{{ t('files', 'Save filter') }}
24-
</NcActionButton>
2521
</template>
2622
</NcActions>
2723
</template>

src/views/FilesList/FileListFilter/FileListFilterModified.vue

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
<template>
66
<FileListFilter :is-active="isActive"
77
:filter-name="t('libresign', 'Modified')"
8-
@reset-filter="resetFilter"
9-
@set-marked-filter="setMarkedFilter">
8+
@reset-filter="resetFilter">
109
<template #icon>
1110
<NcIconSvgWrapper :path="mdiCalendarRange" />
1211
</template>
@@ -107,8 +106,8 @@ export default {
107106
this.setPreset()
108107
} else {
109108
this.setPreset(this.currentPreset)
110-
111109
}
110+
this.setMarkedFilter()
112111
},
113112
},
114113
methods: {
@@ -136,14 +135,11 @@ export default {
136135
this.filtersStore.onFilterUpdateChipsAndSave({ detail: '', id: 'modified' })
137136
}
138137
},
139-
setMarkedFilter(){
140-
138+
setMarkedFilter() {
141139
const chips = []
142-
143-
let preset = this.currentPreset
140+
const preset = this.currentPreset
144141
145142
if (preset) {
146-
147143
chips.push({
148144
start: preset.start,
149145
end: preset.end,
@@ -152,13 +148,10 @@ export default {
152148
id: preset.id,
153149
onclick: () => this.setPreset(),
154150
})
155-
156-
} else {
157-
this.resetFilter()
158151
}
159152
160153
this.filtersStore.onFilterUpdateChipsAndSave({ detail: chips, id: 'modified' })
161-
}
154+
},
162155
},
163156
}
164157
</script>

src/views/FilesList/FileListFilter/FileListFilterStatus.vue

Lines changed: 6 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
<FileListFilter class="file-list-filter-status"
77
:is-active="isActive"
88
:filter-name="t('libresign', 'Status')"
9-
@reset-filter="resetFilter"
10-
@set-marked-filter="setMarkedFilter">
9+
@reset-filter="resetFilter">
1110
<template #icon>
1211
<NcIconSvgWrapper :path="mdiListStatus" />
1312
</template>
@@ -74,6 +73,7 @@ export default {
7473
} else {
7574
this.setPreset(newValue)
7675
}
76+
this.setMarkedFilter()
7777
},
7878
},
7979
methods: {
@@ -99,17 +99,10 @@ export default {
9999
this.filtersStore.onFilterUpdateChips({ detail: chips, id: 'status' })
100100
},
101101
resetFilter() {
102-
103-
if( this.selectedOptions.length > 0) {
102+
if (this.selectedOptions.length > 0) {
104103
this.selectedOptions = []
105-
106104
this.filtersStore.onFilterUpdateChipsAndSave({ detail: [], id: 'status' })
107105
}
108-
109-
console.log("-------------- TESTE:")
110-
console.log(this.selectedOptions)
111-
console.log(this.filtersStore.filterStatusArray)
112-
113106
},
114107
toggleOption(option) {
115108
const idx = this.selectedOptions.indexOf(option)
@@ -119,19 +112,10 @@ export default {
119112
this.selectedOptions.push(option)
120113
}
121114
},
122-
setMarkedFilter(){
123-
124-
console.log("Aqui aqui")
125-
115+
setMarkedFilter() {
126116
const chips = []
127117
128-
let presets = this.selectedOptions
129-
130-
if (presets && presets.length > 0) {
131-
132-
console.log('Caiu no nao reset')
133-
console.log(presets)
134-
118+
if (this.selectedOptions.length > 0) {
135119
for (const id of this.selectedOptions) {
136120
const status = fileStatus.find(item => item.id === id)
137121
if (!status) continue
@@ -145,15 +129,9 @@ export default {
145129
},
146130
})
147131
}
148-
149-
this.filtersStore.onFilterUpdateChipsAndSave({ detail: chips, id: 'status' })
150-
151-
} else {
152-
console.log('Caiu no reset')
153-
this.resetFilter()
154132
}
155133
156-
134+
this.filtersStore.onFilterUpdateChipsAndSave({ detail: chips, id: 'status' })
157135
}
158136
},
159137
}

0 commit comments

Comments
 (0)