Skip to content

Commit 7f94b1d

Browse files
authored
Merge pull request #6254 from LibreSign/backport/6242/stable32
[stable32] feat: envelope support
2 parents 31ccaab + da41c10 commit 7f94b1d

141 files changed

Lines changed: 14596 additions & 3841 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/copilot-instructions.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,29 @@ cd tests/integration
7272
composer i
7373
chown -R www-data: .
7474

75+
# List available test steps
76+
cd tests/integration
77+
runuser -u www-data -- vendor/bin/behat -dl
78+
7579
# Running integration tests (from libresign root directory)
7680
cd tests/integration
7781
runuser -u www-data -- vendor/bin/behat features/<path>.feature
7882

83+
# Run with verbose output (shows nextcloud.log entries)
84+
runuser -u www-data -- vendor/bin/behat features/<path>.feature -v
85+
7986
# Example: Run specific feature file
8087
cd tests/integration
8188
runuser -u www-data -- vendor/bin/behat features/auth/login.feature
8289
```
8390

91+
**CRITICAL**: Like unit tests, ALWAYS run specific scenarios, NEVER run the entire integration test suite:
92+
- Always specify which feature file to run and the row of scenario if needed
93+
- Use `-dl` to list available test steps when writing new tests
94+
- Use `-v` flag to see nextcloud.log output during test execution
95+
- **Important**: steps with OCC command outputs (even with `-v`) don't appear in Behat output but are logged to `nextcloud.log`
96+
- Running all integration tests is extremely slow and resource-intensive
97+
8498
**Frontend Testing**:
8599
```bash
86100
npm test # Jest tests

composer.lock

Lines changed: 102 additions & 70 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/Capabilities.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
namespace OCA\Libresign;
1010

11+
use OCA\Libresign\Service\EnvelopeService;
1112
use OCA\Libresign\Service\SignatureTextService;
1213
use OCA\Libresign\Service\SignerElementsService;
1314
use OCP\App\IAppManager;
@@ -25,6 +26,7 @@ public function __construct(
2526
protected SignerElementsService $signerElementsService,
2627
protected SignatureTextService $signatureTextService,
2728
protected IAppManager $appManager,
29+
protected EnvelopeService $envelopeService,
2830
) {
2931
}
3032

@@ -45,6 +47,9 @@ public function getCapabilities(): array {
4547
'signature-width' => $this->signatureTextService->getSignatureWidth(),
4648
'signature-height' => $this->signatureTextService->getSignatureHeight(),
4749
],
50+
'envelope' => [
51+
'is-available' => $this->envelopeService->isEnabled(),
52+
],
4853
],
4954
'version' => $this->appManager->getAppVersion('libresign'),
5055
];

0 commit comments

Comments
 (0)