Skip to content

Commit 8845a02

Browse files
committed
test: fix thumbnail and middleware PHPUnit regressions
1 parent a9b46aa commit 8845a02

2 files changed

Lines changed: 22 additions & 2 deletions

File tree

tests/php/Api/Controller/FileControllerTest.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,26 @@
99
namespace OCA\Libresign\Tests\Api\Controller;
1010

1111
use OCA\Libresign\AppInfo\Application;
12+
use OCA\Libresign\Db\File as FileEntity;
13+
use OCA\Libresign\Db\FileMapper;
1214
use OCA\Libresign\Tests\Api\ApiTestCase;
1315

1416
/**
1517
* @internal
1618
* @group DB
1719
*/
1820
final class FileControllerTest extends ApiTestCase {
21+
private function getDocumentFileFromResult(FileEntity $file): FileEntity {
22+
if ($file->getNodeType() !== 'envelope') {
23+
return $file;
24+
}
25+
26+
$children = \OCP\Server::get(FileMapper::class)->getChildrenFiles($file->getId());
27+
$this->assertNotEmpty($children, 'Expected envelope to have at least one child file.');
28+
29+
return $children[0];
30+
}
31+
1932
/**
2033
* @runInSeparateProcess
2134
*/
@@ -180,6 +193,7 @@ public function testGetThumbnailByOwner(): void {
180193
]],
181194
'userManager' => $owner,
182195
]);
196+
$file = $this->getDocumentFileFromResult($file);
183197

184198
$this->request
185199
->withRequestHeader([
@@ -216,6 +230,7 @@ public function testGetThumbnailBySigner(): void {
216230
]],
217231
'userManager' => $owner,
218232
]);
233+
$file = $this->getDocumentFileFromResult($file);
219234

220235
$this->request
221236
->withRequestHeader([
@@ -252,6 +267,7 @@ public function testGetThumbnailByNodeIdForSigner(): void {
252267
]],
253268
'userManager' => $owner,
254269
]);
270+
$file = $this->getDocumentFileFromResult($file);
255271

256272
$this->request
257273
->withRequestHeader([

tests/php/Unit/Middleware/InjectionMiddlewareTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use OCA\Libresign\Handler\CertificateEngine\CertificateEngineFactory;
1616
use OCA\Libresign\Helper\ValidateHelper;
1717
use OCA\Libresign\Middleware\InjectionMiddleware;
18+
use OCA\Libresign\Service\FileAccessService;
1819
use OCA\Libresign\Service\SignFileService;
1920
use OCA\Libresign\Service\UuidResolverService;
2021
use OCP\AppFramework\Controller;
@@ -46,11 +47,12 @@ final class InjectionMiddlewareTest extends \OCA\Libresign\Tests\Unit\TestCase {
4647
private CertificateEngineFactory $certificateEngineFactory;
4748
private FileMapper&MockObject $fileMapper;
4849
private IInitialState $initialState;
50+
private FileAccessService&MockObject $fileAccessService;
4951
private SignFileService&MockObject $signFileService;
5052
private UuidResolverService&MockObject $uuidResolverService;
5153
private IL10N&MockObject $l10n;
52-
private IappConfig&MockObject $appConfig;
53-
private IurlGenerator&MockObject $urlGenerator;
54+
private IAppConfig&MockObject $appConfig;
55+
private IURLGenerator&MockObject $urlGenerator;
5456
private ?string $userId = null;
5557

5658
private InitialStateService $initialStateService;
@@ -72,6 +74,7 @@ public function setUp(): void {
7274
$this->createMock(IServerContainer::class)
7375
);
7476
$this->initialState = new InitialState($this->initialStateService, 'libresign');
77+
$this->fileAccessService = $this->createMock(FileAccessService::class);
7578
$this->signFileService = $this->createMock(SignFileService::class);
7679
$this->uuidResolverService = $this->createMock(UuidResolverService::class);
7780
$this->l10n = $this->createMock(IL10N::class);
@@ -88,6 +91,7 @@ public function getInjectionMiddleware(): InjectionMiddleware {
8891
$this->certificateEngineFactory,
8992
$this->fileMapper,
9093
$this->initialState,
94+
$this->fileAccessService,
9195
$this->signFileService,
9296
$this->uuidResolverService,
9397
$this->l10n,

0 commit comments

Comments
 (0)