Merge pull request #6119 from LibreSign/backport/6117/stable32

vitormattos · web-flow · commit 8d2ed4d070d9 · 2025-12-11T15:28:51.000-03:00
[stable32] fix: respect status 0 (DRAFT) when adding new signers
diff --git a/lib/Service/RequestSignatureService.php b/lib/Service/RequestSignatureService.php
@@ -53,7 +53,7 @@ public function __construct(
 	public function save(array $data): FileEntity {
 		$file = $this->saveFile($data);
 		$this->saveVisibleElements($data, $file);
-		if (empty($data['status'])) {
+		if (!isset($data['status'])) {
 			$data['status'] = $file->getStatus();
 		}
 		$this->associateToSigners($data, $file->getId());
@@ -289,6 +289,8 @@ private function associateToSigner(
 	}
 
 	private function determineInitialStatus(int $signingOrder, ?int $fileStatus = null): \OCA\Libresign\Enum\SignRequestStatus {
+		// If fileStatus is explicitly DRAFT (0), keep signer as DRAFT
+		// This allows adding new signers in DRAFT mode even when file is not in DRAFT status
 		if ($fileStatus === FileEntity::STATUS_DRAFT) {
 			return \OCA\Libresign\Enum\SignRequestStatus::DRAFT;
 		}

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function __construct(`
`53`	`53`	`public function save(array $data): FileEntity {`
`54`	`54`	`$file = $this->saveFile($data);`
`55`	`55`	`$this->saveVisibleElements($data, $file);`
`56`		`- if (empty($data['status'])) {`
	`56`	`+ if (!isset($data['status'])) {`
`57`	`57`	`$data['status'] = $file->getStatus();`
`58`	`58`	`}`
`59`	`59`	`$this->associateToSigners($data, $file->getId());`
`@@ -289,6 +289,8 @@ private function associateToSigner(`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`private function determineInitialStatus(int $signingOrder, ?int $fileStatus = null): \OCA\Libresign\Enum\SignRequestStatus {`
	`292`	`+ // If fileStatus is explicitly DRAFT (0), keep signer as DRAFT`
	`293`	`+ // This allows adding new signers in DRAFT mode even when file is not in DRAFT status`
`292`	`294`	`if ($fileStatus === FileEntity::STATUS_DRAFT) {`
`293`	`295`	`return \OCA\Libresign\Enum\SignRequestStatus::DRAFT;`
`294`	`296`	`}`