test: update policy tests to pass appconfig to SignatureFlowPolicy constructor

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

tests/php/Unit/Service/Policy/PolicyServiceTest.php

@@ -13,10 +13,12 @@
 use OCA\Libresign\Service\Policy\PolicyService;
 use OCA\Libresign\Service\Policy\Provider\DocMdp\DocMdpPolicy;
 use OCA\Libresign\Service\Policy\Provider\Footer\FooterPolicy;
+use OCA\Libresign\Service\Policy\Provider\RequestSignGroups\RequestSignGroupsPolicyValue;
 use OCA\Libresign\Service\Policy\Provider\Signature\SignatureFlowPolicy;
 use OCA\Libresign\Service\Policy\Runtime\PolicyContextFactory;
 use OCA\Libresign\Service\Policy\Runtime\PolicyRegistry;
 use OCA\Libresign\Service\Policy\Runtime\PolicySource;
+use OCP\AppFramework\Services\IAppConfig;
 use OCP\Group\ISubAdmin;
 use OCP\IGroupManager;
 use OCP\IL10N;
@@ -52,13 +54,18 @@ protected function setUp(): void {
 
 			return $text;
 		});
+		$appConfig = $this->createMock(IAppConfig::class);
+		// Return all common group IDs to make users eligible by default in tests
+		$appConfig->method('getAppValueString')->willReturn(
+			RequestSignGroupsPolicyValue::encode(['admin', 'finance', 'legal'])
+		);
 		$container = $this->createMock(ContainerInterface::class);
 		$container
 			->method('get')
-			->willReturnCallback(static function (string $class): object {
+			->willReturnCallback(static function (string $class) use ($appConfig): object {
 				return match ($class) {
 					FooterPolicy::class => new FooterPolicy(),
-					SignatureFlowPolicy::class => new SignatureFlowPolicy(),
+					SignatureFlowPolicy::class => new SignatureFlowPolicy($appConfig),
 					DocMdpPolicy::class => new DocMdpPolicy(),
 					default => throw new \RuntimeException('Unexpected provider class: ' . $class),
 				};

tests/php/Unit/Service/Policy/Runtime/PolicyRegistryTest.php

@@ -19,13 +19,19 @@
 use OCA\Libresign\Service\Policy\Provider\RequestSignGroups\RequestSignGroupsPolicyValue;
 use OCA\Libresign\Service\Policy\Provider\Signature\SignatureFlowPolicy;
 use OCA\Libresign\Service\Policy\Runtime\PolicyRegistry;
+use OCP\AppFramework\Services\IAppConfig;
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerInterface;
 
 final class PolicyRegistryTest extends TestCase {
 	public function testRegistryReturnsSignatureFlowDefinition(): void {
+		$appConfig = $this->createMock(IAppConfig::class);
+		$appConfig->method('getAppValueString')->willReturn(
+			RequestSignGroupsPolicyValue::encode(RequestSignGroupsPolicyValue::DEFAULT_GROUPS)
+		);
+
 		$container = $this->createMock(ContainerInterface::class);
-		$container->method('get')->with(SignatureFlowPolicy::class)->willReturn(new SignatureFlowPolicy());
+		$container->method('get')->with(SignatureFlowPolicy::class)->willReturn(new SignatureFlowPolicy($appConfig));
 		$registry = new PolicyRegistry($container);
 		$definition = $registry->get(SignatureFlowPolicy::KEY);
 
@@ -88,8 +94,13 @@ public function testRegistryReturnsRequestSignGroupsDefinition(): void {
 	public function testRegistryThrowsForUnknownPolicy(): void {
 		$this->expectException(\InvalidArgumentException::class);
 
+		$appConfig = $this->createMock(IAppConfig::class);
+		$appConfig->method('getAppValueString')->willReturn(
+			RequestSignGroupsPolicyValue::encode(RequestSignGroupsPolicyValue::DEFAULT_GROUPS)
+		);
+
 		$container = $this->createMock(ContainerInterface::class);
-		$container->method('get')->with(SignatureFlowPolicy::class)->willReturn(new SignatureFlowPolicy());
+		$container->method('get')->with(SignatureFlowPolicy::class)->willReturn(new SignatureFlowPolicy($appConfig));
 		$registry = new PolicyRegistry($container);
 		$registry->get('unknown_policy');
 	}

tests/php/Unit/Service/Policy/Runtime/PolicySourceTest.php

@@ -49,14 +49,12 @@ protected function setUp(): void {
 		$container = $this->createMock(ContainerInterface::class);
 		$container
 			->method('get')
-			->willReturnCallback(static function (string $class): object {
-				return match ($class) {
-					FooterPolicy::class => new FooterPolicy(),
-					SignatureFlowPolicy::class => new SignatureFlowPolicy(),
-					DocMdpPolicy::class => new DocMdpPolicy(),
-					RequestSignGroupsPolicy::class => new RequestSignGroupsPolicy(),
-					default => throw new \RuntimeException('Unexpected provider class: ' . $class),
-				};
+			->willReturnCallback(fn (string $class): object => match ($class) {
+				FooterPolicy::class => new FooterPolicy(),
+				SignatureFlowPolicy::class => new SignatureFlowPolicy($this->appConfig),
+				DocMdpPolicy::class => new DocMdpPolicy(),
+				RequestSignGroupsPolicy::class => new RequestSignGroupsPolicy(),
+				default => throw new \RuntimeException('Unexpected provider class: ' . $class),
 			});
 		$this->registry = new PolicyRegistry($container);
 	}