fix: handle private validation URL redirect and string error messages

When make_validation_url_private=true, the backend returns HTTP 401
with action=REDIRECT and errors as a string array. The frontend was
only handling object-format errors ({message}) and not the redirect
action, causing a false 'Failed to validate document' message.

Adds handleValidationRedirect() and fixes getValidationErrorMessage()
to handle both string and object error formats.

Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

src/components/PdfEditor/PdfEditor.vue

@@ -9,7 +9,7 @@
 			:init-file-names="fileNames"
 			:page-count-format="t('libresign', '{currentPage} of {totalPages}')"
 			:page-aria-label="getPageAriaLabel"
-			:auto-fit-zoom="true"
+			:auto-fit-zoom="enableAutoFitZoom"
 			:read-only="readOnly"
 			:emit-object-click="true"
 			:hide-selection-ui="readOnly"
@@ -129,6 +129,9 @@ type PdfElementsInstance = {
 	pdfDocuments?: PdfDocument[]
 	selectedDocIndex?: number
 	autoFitZoom?: boolean
+	scale?: number
+	visualScale?: number
+	commitZoom?: () => void
 }
 
 defineOptions({
@@ -158,6 +161,17 @@ const emit = defineEmits<{
 
 const pdfElements = ref<PdfElementsInstance | null>(null)
 
+// Auto-fit can fight user zoom on touch devices; keep one-shot fit from endInit and let user control zoom afterwards.
+const enableAutoFitZoom = computed(() => {
+	const isTouchDevice = typeof window !== 'undefined'
+		&& (
+			(window.matchMedia?.('(pointer: coarse)').matches ?? false)
+			|| 'ontouchstart' in window
+			|| (typeof navigator !== 'undefined' && navigator.maxTouchPoints > 0)
+		)
+	return !isTouchDevice
+})
+
 const ignoreClickOutsideSelectors = computed(() => ['.action-item__popper', '.action-item'])
 
 const toolbarStyleVars = computed(() => ({
@@ -313,6 +327,8 @@ function cancelAdding() {
 	pdfElements.value?.cancelAdding()
 }
 
+
+
 async function addSigner(signer: SignerSummaryRecord | SignerDetailRecord, visibleElement: VisibleElementRecord, options: { documentIndex?: number } = {}) {
 	if (!pdfElements.value || !visibleElement.coordinates) {
 		return
@@ -385,6 +401,7 @@ defineExpose({
 	findObjectLocation,
 	startAddingSigner,
 	cancelAdding,
+
 	addSigner,
 	waitForPageRender,
 	getTotalObjectsCount,
@@ -396,6 +413,8 @@ defineExpose({
 .pdf-editor {
 	width: 100%;
 	height: 100%;
+	overflow: hidden;
+	overscroll-behavior: contain;
 }
 
 </style>

src/tests/views/SignPDF/Sign.spec.ts

@@ -1687,6 +1687,54 @@ describe('Sign.vue - signWithTokenCode', () => {
 			expect(wrapper.vm.hasSignatures).toBe(false)
 			expect(wrapper.vm.needCreateSignature).toBe(false)
 		})
+
+		it('shows a mobile orientation hint when signature setup is required on portrait phones', async () => {
+			const { default: realSign } = await import('../../../views/SignPDF/_partials/Sign.vue')
+			const { useSignStore } = await import('../../../store/sign.js')
+			const signStore = useSignStore()
+
+			signStore.document = createSignDocument({
+				nodeType: 'file',
+				signers: [
+					{ signRequestId: 501, me: true },
+				],
+				visibleElements: [
+					{ elementId: 201, fileId: 1, signRequestId: 501, type: 'signature', coordinates: { page: 1, left: 10, top: 20, width: 30, height: 40 } },
+				],
+			})
+
+			Object.defineProperty(window, 'innerWidth', { configurable: true, value: 390, writable: true })
+			Object.defineProperty(window, 'innerHeight', { configurable: true, value: 844, writable: true })
+
+			const wrapper = mount(realSign, {
+				global: {
+					stubs: {
+						NcButton: true,
+						NcDialog: true,
+						NcLoadingIcon: true,
+						TokenManager: true,
+						EmailManager: true,
+						UploadCertificate: true,
+						Documents: true,
+						Signatures: true,
+						Draw: true,
+						ManagePassword: true,
+						CreatePassword: true,
+						NcNoteCard: false,
+						NcPasswordField: true,
+						NcRichText: true,
+					},
+					mocks: {
+						$watch: vi.fn(),
+					},
+				},
+			})
+
+			await flushPromises()
+
+			expect(wrapper.vm.needCreateSignature).toBe(true)
+			expect(wrapper.text()).toContain('For a better signing experience on mobile, rotate your phone to landscape mode.')
+		})
 	})
 
 	describe('Sign.vue - create signature modal', () => {

src/views/SignPDF/_partials/Sign.vue

@@ -8,6 +8,9 @@
 			<Signatures v-if="hasSignatures" />
 		</div>
 		<div v-if="!loading" class="button-wrapper">
+			<NcNoteCard v-if="showMobileOrientationHint" type="warning">
+				{{ t('libresign', 'For a better signing experience on mobile, rotate your phone to landscape mode.') }}
+			</NcNoteCard>
 			<NcNoteCard v-for="(error, index) in signStore.errors"
 				:key="index"
 				:heading="error.title || ''"
@@ -433,6 +436,7 @@ const sidebarStore = useSidebarStore() as SidebarStoreContract
 const identificationDocumentStore = useIdentificationDocumentStore() as IdentificationDocumentStoreContract
 
 const loading = ref(true)
+const isMobilePortrait = ref(false)
 const user = ref<UserInfo>({
 	account: { uid: '', emailAddress: '', displayName: '' },
 	settings: { canRequestSign: false, hasSignatureFile: false, phoneNumber: '' },
@@ -472,6 +476,7 @@ const needCreateSignature = computed(() => {
 	}
 	return hasVisibleElementsForCurrentUser(visibleElementsDocument.value)
 })
+const showMobileOrientationHint = computed(() => needCreateSignature.value && isMobilePortrait.value)
 const needIdentificationDocuments = computed(() => identificationDocumentStore.showDocumentsComponent())
 const canCreateSignature = computed(() => {
 	const capabilities = getCapabilities() as LibresignCapabilities
@@ -543,6 +548,19 @@ function clearBlockingSignError() {
 	signStore.clearSigningErrors()
 }
 
+function updateOrientationHint() {
+	if (typeof window === 'undefined') {
+		isMobilePortrait.value = false
+		return
+	}
+
+	const isMobileViewport = window.innerWidth <= 512
+	const isPortrait = window.matchMedia?.('(orientation: portrait)').matches
+		?? window.innerHeight > window.innerWidth
+
+	isMobilePortrait.value = isMobileViewport && isPortrait
+}
+
 function saveSignature() {
 	if (signatureElementsStore.success.length) {
 		showSuccess(signatureElementsStore.success)
@@ -728,6 +746,10 @@ function executeSigningAction(action: string) {
 }
 
 onMounted(async () => {
+	updateOrientationHint()
+	window.addEventListener('resize', updateOrientationHint, { passive: true })
+	window.addEventListener('orientationchange', updateOrientationHint)
+
 	loading.value = true
 	signatureElementsStore.signRequestUuid = signRequestUuid.value
 	signatureElementsStore.loadSignatures()
@@ -775,6 +797,8 @@ watch(signRequestUuid, (newUuid, oldUuid) => {
 })
 
 onBeforeUnmount(() => {
+	window.removeEventListener('resize', updateOrientationHint)
+	window.removeEventListener('orientationchange', updateOrientationHint)
 	resetSignMethodsState()
 	if (unwatchPendingAction) {
 		unwatchPendingAction()
@@ -792,6 +816,23 @@ defineExpose({
 </script>
 
 <style lang="scss" scoped>
+.document-sign {
+	display: flex;
+	flex-direction: column;
+	height: 100%;
+	width: 100%;
+	overscroll-behavior: contain;
+	-webkit-user-select: none;
+	user-select: none;
+	-webkit-touch-callout: none;
+}
+
+.sign-elements {
+	flex: 1;
+	overflow: hidden;
+	width: 100%;
+}
+
 .progress-indicator {
 	font-weight: bold;
 	color: var(--color-primary-element);

src/views/Validation.vue

@@ -231,10 +231,10 @@ function getValidationErrorMessage(response: ValidationErrorResponse | undefined
 	const errors = response?.data?.ocs?.data?.errors
 	if (errors?.length) {
 		const [firstError] = errors
-		if (typeof firstError === 'string' && firstError.length > 0) {
-			return firstError
+		if (typeof firstError === 'string') {
+			return firstError || fallback
 		}
-		if (typeof firstError?.message === 'string' && firstError.message.length > 0) {
+		if (firstError?.message) {
 			return firstError.message
 		}
 	}