fix: remove signature from store when delete returns 404#6036
Merged
vitormattos merged 1 commit intomainfrom Dec 9, 2025
Merged
fix: remove signature from store when delete returns 404#6036vitormattos merged 1 commit intomainfrom
vitormattos merged 1 commit intomainfrom
Conversation
When attempting to delete a signature that no longer exists on the server (404 response), the signature was not being removed from the Pinia store, leaving stale data in the UI. This fix checks for 404 status in the error handler and clears the signature from the store, ensuring the UI state matches the server state even when the signature was already deleted. Also improved error handling to safely access nested response properties and provide a fallback error message. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to delete a signature that no longer exists on the server (404 response), the signature was not being removed from the Pinia store, leaving stale data in the UI.
This fix checks for 404 status in the error handler and clears the signature from the store, ensuring the UI state matches the server state even when the signature was already deleted.
Also improved error handling to safely access nested response properties and provide a fallback error message.