Skip to content

[stable31] feat: improve signature request confirmation #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Dec 13, 2025
Merged

[stable31] feat: improve signature request confirmation #6179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a13c27
refactor: change VisibleElements modal button from Send to Save
vitormattos Dec 13, 2025
36a8219
feat: add confirmation dialogs for signature requests
vitormattos Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 2 additions & 53 deletions src/Components/Request/VisibleElements.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
:variant="variantOfSaveButton"
:wide="true"
:class="{ disabled: signerSelected }"
@click="isDraft ? save() : showConfirm = true">
{{ isDraft ? t('libresign', 'Save') : t('libresign', 'Send') }}
@click="save()">
{{ t('libresign', 'Save') }}
</NcButton>

<NcButton v-if="canSign"
Expand All @@ -61,31 +61,6 @@
@pdf-editor:end-init="updateSigners"
@pdf-editor:on-delete-signer="onDeleteSigner" />
</div>
<NcDialog v-if="showConfirm"
:open.sync="showConfirm"
:name="t('libresign', 'Confirm')"
:no-close="loading"
:message="t('libresign', 'Send signature request?')">
<NcNoteCard v-if="errorConfirmRequest.length > 0"
type="error">
{{ errorConfirmRequest }}
</NcNoteCard>
<template #actions>
<NcButton :disabled="loading"
@click="showConfirm = false">
{{ t('libresign', 'Cancel') }}
</NcButton>
<NcButton variant="primary"
:disabled="loading"
@click="request">
<template #icon>
<NcLoadingIcon v-if="loading" :size="20" name="Loading" />
<Send v-else :size="20" />
</template>
{{ t('libresign', 'Send') }}
</NcButton>
</template>
</NcDialog>
</NcDialog>
</template>

Expand All @@ -102,8 +77,6 @@ import NcDialog from '@nextcloud/vue/components/NcDialog'
import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'

import Send from 'vue-material-design-icons/Send.vue'

import Chip from '../Chip.vue'
import PdfEditor from '../PdfEditor/PdfEditor.vue'
import Signer from '../Signers/Signer.vue'
Expand All @@ -121,7 +94,6 @@ export default {
NcButton,
NcLoadingIcon,
PdfEditor,
Send,
},
setup() {
const filesStore = useFilesStore()
Expand All @@ -131,9 +103,7 @@ export default {
return {
canRequestSign: loadState('libresign', 'can_request_sign', false),
modal: false,
showConfirm: false,
loading: false,
errorConfirmRequest: '',
signerSelected: null,
width: getCapabilities().libresign.config['sign-elements']['full-signature-width'],
height: getCapabilities().libresign.config['sign-elements']['full-signature-height'],
Expand Down Expand Up @@ -204,7 +174,6 @@ export default {
this.filesStore.loading = true
},
closeModal() {
this.errorConfirmRequest = ''
this.modal = false
this.filesStore.loading = false
},
Expand Down Expand Up @@ -306,26 +275,6 @@ export default {
return false
}
},
async request() {
this.loading = true
this.errorConfirmRequest = ''
const visibleElements = this.buildVisibleElements()

try {
const response = await this.filesStore.updateSignatureRequest({ visibleElements, status: 1 })
this.filesStore.addFile(response.data)
this.showConfirm = false
showSuccess(t('libresign', response.message))
this.closeModal()
emit('libresign:visible-elements-saved')
this.loading = false
return true
} catch (error) {
this.errorConfirmRequest = error.response?.data?.ocs?.data?.message || t('libresign', 'An error occurred')
this.loading = false
return false
}
},
buildVisibleElements() {
const visibleElements = []
const scale = this.$refs.pdfEditor.$refs.vuePdfEditor.scale || 1
Expand Down
55 changes: 54 additions & 1 deletion src/Components/RightSidebar/RequestSignatureTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,44 @@
</NcAppSidebarTab>
</NcAppSidebar>
</NcDialog>
<NcDialog v-if="showConfirmRequest"
:name="t('libresign', 'Confirm')"
:message="t('libresign', 'Send signature request?')"
@closing="showConfirmRequest = false">
<template #actions>
<NcButton @click="showConfirmRequest = false">
{{ t('libresign', 'Cancel') }}
</NcButton>
<NcButton variant="primary"
:disabled="hasLoading"
@click="confirmRequest">
<template #icon>
<NcLoadingIcon v-if="hasLoading" :size="20" />
<Send v-else :size="20" />
</template>
{{ t('libresign', 'Send') }}
</NcButton>
</template>
</NcDialog>
<NcDialog v-if="showConfirmRequestSigner"
:name="t('libresign', 'Confirm')"
:message="t('libresign', 'Send signature request?')"
@closing="showConfirmRequestSigner = false; selectedSigner = null">
<template #actions>
<NcButton @click="showConfirmRequestSigner = false; selectedSigner = null">
{{ t('libresign', 'Cancel') }}
</NcButton>
<NcButton variant="primary"
:disabled="hasLoading"
@click="confirmRequestSigner">
<template #icon>
<NcLoadingIcon v-if="hasLoading" :size="20" />
<Send v-else :size="20" />
</template>
{{ t('libresign', 'Send') }}
</NcButton>
</template>
</NcDialog>
</div>
</template>
<script>
Expand Down Expand Up @@ -241,6 +279,9 @@ export default {
document: {},
hasInfo: false,
methods: [],
showConfirmRequest: false,
showConfirmRequestSigner: false,
selectedSigner: null,
}
},
computed: {
Expand Down Expand Up @@ -518,11 +559,17 @@ export default {

},
async requestSignatureForSigner(signer) {
this.selectedSigner = signer
this.showConfirmRequestSigner = true
},
async confirmRequestSigner() {
if (!this.selectedSigner) return

this.hasLoading = true
try {
const file = this.filesStore.getFile()
const signers = file.signers.map(s => {
if (s.signRequestId === signer.signRequestId) {
if (s.signRequestId === this.selectedSigner.signRequestId) {
return { ...s, status: 1 }
}
return s
Expand All @@ -532,6 +579,8 @@ export default {
signers,
})
showSuccess(t('libresign', 'Signature requested'))
this.showConfirmRequestSigner = false
this.selectedSigner = null
} catch (error) {
if (error.response?.data?.ocs?.data?.message) {
showError(error.response.data.ocs.data.message)
Expand Down Expand Up @@ -572,10 +621,14 @@ export default {
this.hasLoading = false
},
async request() {
this.showConfirmRequest = true
},
async confirmRequest() {
this.hasLoading = true
try {
const response = await this.filesStore.updateSignatureRequest({ visibleElements: [], status: 1 })
showSuccess(t('libresign', response.message))
this.showConfirmRequest = false
} catch (error) {
if (error.response?.data?.ocs?.data?.message) {
showError(error.response.data.ocs.data.message)
Expand Down
Loading