Merged
Conversation
Created dedicated service to handle file status management. Includes updateFileStatusIfUpgrade to upgrade file status and canNotifySigners to validate if file status allows notifications. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Created dedicated service to manage sign request status determination and validation. Implements shouldNotifySignRequest, canNotifySignRequest, updateStatusIfAllowed, determineInitialStatus, and private helper methods for status calculation based on file status, signer status, signing order, and flow type (parallel/sequential). Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Injected FileStatusService and SignRequestStatusService to delegate all status-related operations. Removed status determination methods and notification validation logic, delegating to specialized services. Updated method calls to use appropriate service methods. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Created test suite with 23 tests covering all file status upgrade scenarios and notification validation. Uses PHP 8 DataProvider attributes for parameterized testing. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Created test suite with 53 tests validating business rules for sign request status determination. Covers notification scenarios, status updates, and initial status calculation based on file status, signer status, signing order, and flow type. Uses PHP 8 DataProvider attributes for parameterized testing. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Updated tests to inject FileStatusService and SignRequestStatusService mocks. Added specific tests validating parallel and ordered flow behavior with correct parameter ordering for determineInitialStatus. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ervice IAppConfig was injected but never used in any method. Removed dependency to clean up constructor. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Removed IAppConfig mock from test setup to match updated service constructor signature. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.