feat: policy signature flow by vitormattos · Pull Request #7518 · LibreSign/libresign

vitormattos · 2026-04-14T17:54:30Z

No description provided.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…plate is empty When all admin-level customizations are deleted, the policy's inheritedValue has an empty footerTemplate. Previously resolveEditorProps unconditionally overrode baseEditorProps.inheritedTemplate with that empty string, silently discarding the system-level default injected by PHP via loadState('libresign', 'footer_template', ''). Now resolveEditorProps only overrides inheritedTemplate when the inherited level provides a non-empty custom footer template. Otherwise it falls back to baseEditorProps.inheritedTemplate, preserving the real system default so the user reset button always restores a meaningful value instead of blank. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…rect fallback Replace the two tests that were asserting the broken behavior (inheritedTemplate overwritten with '' when policy has empty footerTemplate) with correct expectations: - empty inheritedValue footerTemplate → falls back to base (system default) - empty inheritedValue when no inheritedValue property → keeps base - non-empty inheritedValue footerTemplate → properly overrides base Also add test for the non-empty case to cover the full matrix. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…is resolved The showTemplateResetButton:false override was added as a workaround when inheritedTemplate was always empty in the user Preferences context (because resolveEditorProps was discarding the loadState fallback). Now that resolveEditorProps correctly falls back to the PHP-injected system-level footer template when no admin-level template is configured, inheritedTemplate is always properly resolved. Remove the guard so the editor's own showResetTemplateButton computed takes over: - hidden when currentTemplate == inheritedTemplate (nothing to reset) - shown when the user's template differs from the inherited default This allows users to reset just their footer template back to the inherited default (instance admin > group admin > system default) without having to clear their entire preference. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…sentinel Previously onTemplateReset and onCustomizeFooterTemplateChange used footerTemplate:'' as a sentinel meaning 'use the inherited template'. This sentinel relied on the value-computed hook to inject inheritedTemplate at display time, but the emitted model value carried '' — which gets saved to the user preference as-is. On the next page load, if inheritedTemplate resolved to something different (or to '' because no admin customization exists), the display and the preference diverged, showing blank or the wrong value after reset. Fix: make both operations save the concrete value: - onTemplateReset now saves footerTemplate:props.inheritedTemplate so the preference stores the real inherited default explicitly. - onCustomizeFooterTemplateChange (enable path) now seeds the template with the current display value (which already incorporates inheritedTemplate via the computed) so enabling customization never stores an empty template when an inherited default is available. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…r reset Update the 'restores inherited template in editor after reset' test: the emitted model value after onTemplateReset must now contain footerTemplate:'Inherited footer template' (the concrete inherited value) instead of footerTemplate:'' (the old empty-sentinel behavior that caused saved preferences to diverge from the displayed template). Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…RuleEditor Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added this to the Next Major (34) milestone Apr 14, 2026

vitormattos self-assigned this Apr 14, 2026

github-project-automation bot added this to Roadmap Apr 14, 2026

github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 14, 2026

vitormattos marked this pull request as draft April 14, 2026 17:54

vitormattos added 25 commits April 14, 2026 14:56

feat(policy): update ResolvedPolicy.php

4a23d99

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update FooterPolicy.php

5a3b517

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update FooterPolicyValue.php

459a134

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update DefaultPolicyResolver.php

3a36d9c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update policy-preferences-visibility.spec.ts

5b16bff

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(ui): update CodeEditor.vue

ea6a85c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update Preferences.spec.ts

ef85ea3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update signatureFooterModel.spec.ts

d145e55

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update signatureFooterRuleEditor.spec.ts

a518aba

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update useRealPolicyWorkbench.spec.ts

97a7073

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update SettingsPolicyWorkbench.spec.ts

2bdf747

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update Preferences.vue

7741c36

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update PolicyRuleEditorPanel.vue

eb9b143

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update RealPolicyWorkbench.vue

bebf242

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update realTypes.ts

afb6fb5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update SignatureFooterRuleEditor.vue

9ea4796

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update model.ts

6bb08a1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update realDefinition.ts

9ab99bd

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): update useRealPolicyWorkbench.ts

82aaa91

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update PageControllerTest.php

acfdd6d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update PolicyServiceTest.php

c4d9de6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(policy): update FooterPolicyTest.php

c48a968

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(api): accept footer policy override in request-signature controller

3ae5cc1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(policy): resolve add_footer request overrides on signature requests

7d337c6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat(footer): support request-level policy overrides during rendering

c89382f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added 30 commits April 14, 2026 23:28

chore: require psr http client for psalm

d37fde3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: lock psr http client dependencies

766c081

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: hide immutable override toggle in policy editor

d66bb4f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover hidden immutable override toggle

f46fad8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat: add autosave feedback and undo in preferences

8b771ee

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover autosave undo in preferences

86d20a4

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: simplify preferences autosave ui

65745f7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover simplified preferences autosave behavior

fbb5e73

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: prevent autosave feedback layout shift

7a16a4b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: stub loading icon in preferences spec

8943711

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: clear undo snapshot after undoing preference change

539b0d8

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: assert undo arrow hidden after undoing preference

02a012e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: show reset button when user has a saved preference on page load

a18fb67

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover reset button visibility on page load and undo label logic

83321a0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: anchor undo button inside editor shell instead of floating toolbar

a8f6932

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: move undo button above editor shell with visible text label

b4ed039

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: verify reset button shows for add_footer on page load

505695b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: make preferences action reset-only without transient undo state

e0df1d1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: allow hiding footer template reset button via prop

5d6299e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: update preferences specs for reset-only behavior

1e081f3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover hidden template reset button option

6752e8e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

style(signature-footer): remove redundant comment in resolveEditorProps

b0ab195

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

style(signature-footer): remove redundant comments in SignatureFooter…

b9b9567

…RuleEditor Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: align footer policy reset behavior

8948f20

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: restore footer template policy sync and default state

fdf07d9

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: policy signature flow#7518

feat: policy signature flow#7518
vitormattos wants to merge 928 commits intomainfrom
feat/policy-signature-flow-phase1-groundwork

vitormattos commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vitormattos commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant