fix: avoid crash on hostless LDAP CRL URLs#7523
Merged
vitormattos merged 15 commits intomainfrom Apr 21, 2026
Merged
Conversation
Handle parse_url(PHP_URL_SCHEME) returning non-string values for hostless LDAP URLs such as ldap:///... used by some AD certificate CRL distribution points.\n\nThis prevents a TypeError in scheme detection and adds regression coverage for hostless LDAP URL recognition. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Create a minimal defaultContact.vcf fixture in unit test setup to prevent warning-level failures on Nextcloud master when DAV tries to read the example contact file.\n\nThis keeps phpunit runs stable with --fail-on-warning across DB matrix jobs. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/ldap-hostless-crl-url
branch
from
105a00c to
df7ed74
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_url(..., PHP_URL_SCHEME)does not return a stringldap:///...) without triggering runtime errorsProblem
Some certificates expose CRL distribution points using hostless LDAP URLs. In this case, scheme extraction can produce a non-string value and cause a runtime error during LDAP URL detection.
Fix
strtolowerldap://andldaps://patterns when the parsed scheme is not a stringTests
composer test:unit -- --filter LdapCrlDownloaderTestcomposer test:unit -- --filter CrlRevocationCheckerTestNotes
This change intentionally keeps CRL validation strict: invalid/inaccessible endpoints return controlled validation statuses instead of crashing the request.