fix: handle private validation URL redirect and string error messages#7543
Merged
vitormattos merged 2 commits intomainfrom Apr 23, 2026
Merged
fix: handle private validation URL redirect and string error messages#7543vitormattos merged 2 commits intomainfrom
vitormattos merged 2 commits intomainfrom
Conversation
When make_validation_url_private=true, the backend returns HTTP 401
with action=REDIRECT and errors as a string array. The frontend was
only handling object-format errors ({message}) and not the redirect
action, causing a false 'Failed to validate document' message.
Adds handleValidationRedirect() and fixes getValidationErrorMessage()
to handle both string and object error formats.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
When make_validation_url_private=true, the backend returns HTTP 401
with action=REDIRECT and errors as a string array. The frontend was
only handling object-format errors ({message}) and not the redirect
action, causing a false 'Failed to validate document' message.
Adds handleValidationRedirect() and fixes getValidationErrorMessage()
to handle both string and object error formats.
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/private-validation-redirect
branch
from
fb54360 to
b54bd4a
Compare
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
make_validation_url_private=true, the backend returns HTTP 401 withaction=REDIRECTanderrorsas a string array. The frontend was only handling object-format errors ({message}) and not the redirect action, causing a false "Failed to validate document" message instead of redirecting to the login page.Changes
handleValidationRedirect()to detectaction=REDIRECTresponses and redirect to the backend-provided URLgetValidationErrorMessage()to handle both string and object error formats