Skip to content

refactor: signer TSA component and simplify CRL validation messaging#7612

Merged
vitormattos merged 15 commits intomainfrom
feat/tsa-signer-crl-validation-flow
Apr 25, 2026
Merged

refactor: signer TSA component and simplify CRL validation messaging#7612
vitormattos merged 15 commits intomainfrom
feat/tsa-signer-crl-validation-flow

Conversation

@vitormattos
Copy link
Copy Markdown
Member

Summary

  • extract signer timestamp UI into dedicated SignerTimestamp component
  • simplify CRL status messaging to focus on business outcome (revoked before signing vs valid at signing)
  • remove legacy top-level TSA compatibility checks in validation document tests
  • introduce CertificateSignersMergeService and update SignersLoader to delegate merge logic
  • support optional revocation timestamp override in CRL mapper/service
  • offset click-to-sign automatic revocation timestamp by +1 second to avoid tie with signing time

Commit Strategy

  • one signed-off commit per file (-s), as requested

Tests

  • npx vitest run src/tests/components/validation/SignerDetails.spec.ts src/tests/components/validation/SignerTimestamp.spec.ts src/tests/services/validationDocument.spec.ts
  • composer test:unit -- --filter 'RevokeClickToSignCertificateListenerTest|CrlServiceTest|SignersLoaderTest|CertificateSignersMergeServiceTest'
  • npm run ts:check

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Apr 25, 2026
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable33

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@vitormattos vitormattos merged commit baf37ef into main Apr 25, 2026
77 checks passed
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 25, 2026
@vitormattos vitormattos deleted the feat/tsa-signer-crl-validation-flow branch April 25, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

1 participant